Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Obs ai assistant] Set the index pattern on the context api to generate correct ES|QL queries etc #182090

Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 30, 2024

Summary

Reverting the revert of #181001 (comment)

the only change is the removal of the ml plugin dependency from the obs-ai-assistant

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula changed the title Discover set dataview context circular deps [Discover][Obs ai assistant] Set the index pattern on the context api to generate correct ES|QL queries etc Apr 30, 2024
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana Feature:Discover Discover Application Team:Obs AI Assistant Observability AI Assistant labels Apr 30, 2024
@stratoula stratoula marked this pull request as ready for review April 30, 2024 12:41
@stratoula stratoula requested review from a team as code owners April 30, 2024 12:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 636.1KB 636.4KB +287.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 34.8KB 34.9KB +52.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 30, 2024
@stratoula stratoula enabled auto-merge (squash) April 30, 2024 13:08
@stratoula stratoula disabled auto-merge April 30, 2024 13:09
@stratoula stratoula merged commit 74fdd1b into elastic:main Apr 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants