-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Obs ai assistant] Set the index pattern on the context api to generate correct ES|QL queries etc #181001
Conversation
… to generate correct ES|QL queries
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Should be probably aligned with |
Maybe it is not clear from my description but this is a bug fix, the index pattern is not correctly passed to the LLM creating wrong ES|QL queries. This functionality is already out in the wild, I am not adding something new here (from the functionality perspective), I am fixing a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (on the AI Assistant usage)
Gathering here the outcome of an offline discussion I had with some folks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
…text api to generate correct ES|QL queries etc (elastic#181001)" This reverts commit 9edb9d5.
Reverted in #182088 |
… to generate correct ES|QL queries etc (#182090) ## Summary Reverting the revert of #181001 (comment) the only change is the removal of the ml plugin dependency from the obs-ai-assistant --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Sets the index pattern correctly in the obs ai assistant.
The Obs ai assistant is part of Discover in serverless Oblt project and can also be set up everywhere from the Observability AI Assistant scope advanced setting. It is a very useful tool for the Discover users and for moving from KQL to ES|QL world.
This is important for prompts such as:
Other interesting prompts: