Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [EDR Workflows] Proper undefined routeState handling (#181432) #181529

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

elastic#181261

Check if `routeState` is defined before accessing it's properties in
`useCallback` dependency list.

With changes:

https://github.com/elastic/kibana/assets/29123534/4561c5d6-e354-4e0b-ac8a-dd231a26d722

Cypress tests when no undefined check is performed (application throws):
![Screenshot 2024-04-23 at 14 46
37](https://github.com/elastic/kibana/assets/29123534/ed7817dc-f11c-4f5e-bdf3-c6ee9f4c8ea6)

(cherry picked from commit 800289c)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.6MB 14.6MB +15.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@kibanamachine kibanamachine merged commit 6179dbe into elastic:8.14 Apr 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants