[EDR Workflows] Proper undefined routeState handling #181432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
release_note:skip
szwarckonrad
changed the title
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
/ci |
ashokaditya
reviewed
Apr 23, 2024
| @@ -457,7 +457,7 @@ export const PolicyTabs = React.memo(() => { | |||
| cancelUnsavedChangesModal, | |||
| history, | |||
| policyId, | |||
| routeState.backLink, | |||
| routeState?.backLink, | |||
There was a problem hiding this comment.
This is the only change that fixes the issue. Right? I'm not sure what the nextTabId is needed for.
There was a problem hiding this comment.
I think that's only additional testing: nextTabId is in the artifact_page.ts fixture which is used to click through the artifact tabs on Policy Details page. so with nextTabId an additional click to the neighbour tab is added, to cover this situation
There was a problem hiding this comment.
@ashokaditya What @gergoabraham said :D
gergoabraham
approved these changes
Apr 23, 2024
|
/ci |
ashokaditya
approved these changes
Apr 24, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 24, 2024
elastic#181261 Check if `routeState` is defined before accessing it's properties in `useCallback` dependency list. With changes: https://github.com/elastic/kibana/assets/29123534/4561c5d6-e354-4e0b-ac8a-dd231a26d722 Cypress tests when no undefined check is performed (application throws):  (cherry picked from commit 800289c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 24, 2024
…#181529) # Backport This will backport the following commits from `main` to `8.14`: - [[EDR Workflows] Proper undefined routeState handling (#181432)](#181432) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T08:59:00Z","message":"[EDR Workflows] Proper undefined routeState handling (#181432)\n\nhttps://github.com//issues/181261\r\n\r\nCheck if `routeState` is defined before accessing it's properties in\r\n`useCallback` dependency list.\r\n\r\nWith changes:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/4561c5d6-e354-4e0b-ac8a-dd231a26d722\r\n\r\nCypress tests when no undefined check is performed (application throws):\r\n","sha":"800289c506aeceb7e1dffa650481d7e10dc5e70c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.14.0","v8.15.0"],"title":"[EDR Workflows] Proper undefined routeState handling","number":181432,"url":"https://github.com/elastic/kibana/pull/181432","mergeCommit":{"message":"[EDR Workflows] Proper undefined routeState handling (#181432)\n\nhttps://github.com//issues/181261\r\n\r\nCheck if `routeState` is defined before accessing it's properties in\r\n`useCallback` dependency list.\r\n\r\nWith changes:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/4561c5d6-e354-4e0b-ac8a-dd231a26d722\r\n\r\nCypress tests when no undefined check is performed (application throws):\r\n","sha":"800289c506aeceb7e1dffa650481d7e10dc5e70c"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181432","number":181432,"mergeCommit":{"message":"[EDR Workflows] Proper undefined routeState handling (#181432)\n\nhttps://github.com//issues/181261\r\n\r\nCheck if `routeState` is defined before accessing it's properties in\r\n`useCallback` dependency list.\r\n\r\nWith changes:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/4561c5d6-e354-4e0b-ac8a-dd231a26d722\r\n\r\nCypress tests when no undefined check is performed (application throws):\r\n","sha":"800289c506aeceb7e1dffa650481d7e10dc5e70c"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181261
Check if
routeStateis defined before accessing it's properties inuseCallbackdependency list.With changes:
Screen.Recording.2024-04-23.at.14.22.00.mov
Cypress tests when no undefined check is performed (application throws):
