Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value list UI and telemetry #180929

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Value list UI and telemetry #180929

merged 9 commits into from
Apr 24, 2024

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Apr 16, 2024 •
edited by kibanamachine
Loading

Add telemetry and change UI copy for value list:

Screenshot 2024-04-17 at 15 09 47 Screenshot 2024-04-17 at 15 09 41 Screenshot 2024-04-17 at 15 09 30 Screenshot 2024-04-17 at 15 09 24 Screenshot 2024-04-17 at 15 09 18

nastasha-solomon
nastasha-solomon reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates, @nkhristinin! I left two small edits and one question for @approksiu.

x-pack/plugins/security_solution/public/value_list/translations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security_solution/public/value_list/translations.ts Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon mentioned this pull request Apr 17, 2024
Closed
@nkhristinin nkhristinin added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely and removed ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Apr 22, 2024
@nkhristinin nkhristinin marked this pull request as ready for review April 22, 2024 19:53
@nkhristinin nkhristinin requested review from a team as code owners April 22, 2024 19:53
@nkhristinin nkhristinin requested a review from dplumlee April 22, 2024 19:53
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Apr 23, 2024
@nkhristinin nkhristinin requested a review from a team as a code owner April 23, 2024 12:49
@nkhristinin nkhristinin requested a review from e40pud April 23, 2024 12:49
@yctercero yctercero added the ci:cloud-redeploy Always create a new Cloud deployment label Apr 23, 2024
dplumlee
dplumlee approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry code looks good, thanks for adding this!

@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 24, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.6MB 14.6MB +353.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 82.2KB 82.5KB +267.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

e40pud
e40pud approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkhristinin nkhristinin merged commit 18e6bf2 into elastic:main Apr 24, 2024
35 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 24, 2024
@nkhristinin
Value list UI and telemetry (elastic#180929)
f6f882a 
## Add telemetry and change UI copy for value list:
<img width="1469" alt="Screenshot 2024-04-17 at 15 09 47"
src="https://github.com/elastic/kibana/assets/7609147/6c69c7ed-f8ac-49d0-9a9c-ede199993aaa">
<img width="1432" alt="Screenshot 2024-04-17 at 15 09 41"
src="https://github.com/elastic/kibana/assets/7609147/a5641217-61b0-40a5-afc8-6f1a936be007">
<img width="1576" alt="Screenshot 2024-04-17 at 15 09 30"
src="https://github.com/elastic/kibana/assets/7609147/fd26254e-fc69-4565-85df-8621f6ba7c7a">
<img width="804" alt="Screenshot 2024-04-17 at 15 09 24"
src="https://github.com/elastic/kibana/assets/7609147/0bb76536-3388-41d1-b6cb-9c00992b361e">
<img width="1484" alt="Screenshot 2024-04-17 at 15 09 18"
src="https://github.com/elastic/kibana/assets/7609147/5bf6fcee-01fe-408f-b923-b5824dde7394">

---------

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 18e6bf2)
@kibanamachine kibanamachine mentioned this pull request Apr 24, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 25, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
@nkhristinin @nastasha-solomon
@kibanamachine @kpatticha
Value list UI and telemetry (elastic#180929)
9cc0bfe 
## Add telemetry and change UI copy for value list:
<img width="1469" alt="Screenshot 2024-04-17 at 15 09 47"
src="https://github.com/elastic/kibana/assets/7609147/6c69c7ed-f8ac-49d0-9a9c-ede199993aaa">
<img width="1432" alt="Screenshot 2024-04-17 at 15 09 41"
src="https://github.com/elastic/kibana/assets/7609147/a5641217-61b0-40a5-afc8-6f1a936be007">
<img width="1576" alt="Screenshot 2024-04-17 at 15 09 30"
src="https://github.com/elastic/kibana/assets/7609147/fd26254e-fc69-4565-85df-8621f6ba7c7a">
<img width="804" alt="Screenshot 2024-04-17 at 15 09 24"
src="https://github.com/elastic/kibana/assets/7609147/0bb76536-3388-41d1-b6cb-9c00992b361e">
<img width="1484" alt="Screenshot 2024-04-17 at 15 09 18"
src="https://github.com/elastic/kibana/assets/7609147/5bf6fcee-01fe-408f-b923-b5824dde7394">

---------

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@nastasha-solomon nastasha-solomon mentioned this pull request Apr 30, 2024
Closed
nkhristinin added a commit that referenced this pull request May 15, 2024
@kibanamachine @nkhristinin
[8.14] Value list UI and telemetry (#180929) (#181591)
be2e6bd 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Value list UI and telemetry
(#180929)](#180929)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T15:21:25Z","message":"Value
list UI and telemetry (#180929)\n\n## Add telemetry and change UI copy
for value list:\r\n<img width=\"1469\" alt=\"Screenshot 2024-04-17 at 15
09
47\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/6c69c7ed-f8ac-49d0-9a9c-ede199993aaa\">\r\n<img
width=\"1432\" alt=\"Screenshot 2024-04-17 at 15 09
41\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/a5641217-61b0-40a5-afc8-6f1a936be007\">\r\n<img
width=\"1576\" alt=\"Screenshot 2024-04-17 at 15 09
30\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/fd26254e-fc69-4565-85df-8621f6ba7c7a\">\r\n<img
width=\"804\" alt=\"Screenshot 2024-04-17 at 15 09
24\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/0bb76536-3388-41d1-b6cb-9c00992b361e\">\r\n<img
width=\"1484\" alt=\"Screenshot 2024-04-17 at 15 09
18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/5bf6fcee-01fe-408f-b923-b5824dde7394\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Nastasha Solomon
<[email protected]>\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"18e6bf2caedf1362f9ecb45f67683112795b6fbf","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:cloud-deploy","ci:cloud-redeploy","v8.15.0"],"title":"Value
list UI and
telemetry","number":180929,"url":"https://github.com/elastic/kibana/pull/180929","mergeCommit":{"message":"Value
list UI and telemetry (#180929)\n\n## Add telemetry and change UI copy
for value list:\r\n<img width=\"1469\" alt=\"Screenshot 2024-04-17 at 15
09
47\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/6c69c7ed-f8ac-49d0-9a9c-ede199993aaa\">\r\n<img
width=\"1432\" alt=\"Screenshot 2024-04-17 at 15 09
41\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/a5641217-61b0-40a5-afc8-6f1a936be007\">\r\n<img
width=\"1576\" alt=\"Screenshot 2024-04-17 at 15 09
30\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/fd26254e-fc69-4565-85df-8621f6ba7c7a\">\r\n<img
width=\"804\" alt=\"Screenshot 2024-04-17 at 15 09
24\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/0bb76536-3388-41d1-b6cb-9c00992b361e\">\r\n<img
width=\"1484\" alt=\"Screenshot 2024-04-17 at 15 09
18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/5bf6fcee-01fe-408f-b923-b5824dde7394\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Nastasha Solomon
<[email protected]>\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"18e6bf2caedf1362f9ecb45f67683112795b6fbf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180929","number":180929,"mergeCommit":{"message":"Value
list UI and telemetry (#180929)\n\n## Add telemetry and change UI copy
for value list:\r\n<img width=\"1469\" alt=\"Screenshot 2024-04-17 at 15
09
47\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/6c69c7ed-f8ac-49d0-9a9c-ede199993aaa\">\r\n<img
width=\"1432\" alt=\"Screenshot 2024-04-17 at 15 09
41\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/a5641217-61b0-40a5-afc8-6f1a936be007\">\r\n<img
width=\"1576\" alt=\"Screenshot 2024-04-17 at 15 09
30\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/fd26254e-fc69-4565-85df-8621f6ba7c7a\">\r\n<img
width=\"804\" alt=\"Screenshot 2024-04-17 at 15 09
24\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/0bb76536-3388-41d1-b6cb-9c00992b361e\">\r\n<img
width=\"1484\" alt=\"Screenshot 2024-04-17 at 15 09
18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7609147/5bf6fcee-01fe-408f-b923-b5824dde7394\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Nastasha Solomon
<[email protected]>\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"18e6bf2caedf1362f9ecb45f67683112795b6fbf"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
@kibanamachine kibanamachine added v8.14.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 15, 2024
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon left review comments

@approksiu approksiu approksiu left review comments

@dplumlee dplumlee dplumlee approved these changes

@e40pud e40pud e40pud approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nkhristinin @kibana-ci @kibanamachine @e40pud @approksiu @dplumlee @nastasha-solomon @yctercero