Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI copy]: for value list modal #5072

Closed
nkhristinin opened this issue Apr 11, 2024 · 7 comments
Closed

[UI copy]: for value list modal #5072

nkhristinin opened this issue Apr 11, 2024 · 7 comments
Assignees
Labels
Effort: Small Issues that can be resolved quickly Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine ui-copy v8.14.0

Comments

@nkhristinin
Copy link
Contributor

nkhristinin commented Apr 11, 2024

Description

Value list modal window - more info in the docs issue: #5052

Related links / assets

Screenshot 2024-04-15 at 17 17 05 Screenshot 2024-04-15 at 17 16 53 Screenshot 2024-04-15 at 17 16 47 Screenshot 2024-04-15 at 17 16 42

PR: elastic/kibana#179339

Which documentation set does this change impact?

ESS and serverless

Feature differences

identical

Software version

new from 8.14

Collaborators

PM: @approksiu
Designer: @ARWNightingale
Developer: @nkhristinin
Others (if applicable):

Timeline / deliverables

8.14

@jmikell821
Copy link
Contributor

Hi @nkhristinin, thanks for filing this. Can you please attach a screenshot of the value list modal that needs copy review? Is it just one modal that needs UI copy or are there other components in the Kibana PR you linked that we need to review as well?

@nkhristinin
Copy link
Contributor Author

nkhristinin commented Apr 11, 2024

Hi @nkhristinin, thanks for filing this. Can you please attach a screenshot of the value list modal that needs copy review? Is it just one modal that needs UI copy or are there other components in the Kibana PR you linked that we need to review as well?

In this issue, you will see a video - it's only a modal window is new

#5052

@nastasha-solomon
Copy link
Contributor

nastasha-solomon commented Apr 11, 2024

@nkhristinin @ARWNightingale, following up on @approksiu's question here:

Is the Import value lists button being renamed? If so, what's the new button name, and when will users be able to see this change in the value list UI? (Which Serverless and Stack release will users be able to see the renamed button?)

If the Import value lists button is renamed, I'll need to update additional docs and images. Multiple places throughout the UI and API docs reference the Import value lists button, so I'll need to update all of those instances. I'll also need to refresh screenshots that show the Import value lists button to ensure they're up-to-date and correct.

@nkhristinin
Copy link
Contributor Author

Is the Import value lists button being renamed?

I didn't change any old UI, all UI in modal window is new one

@approksiu
Copy link
Contributor

@nastasha-solomon I am suggesting to rename "Import value lists" link to "Value lists".
image
Could you please take a look at the tooltip as well here:
image
cc @ARWNightingale @nkhristinin

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon added Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.14.0 labels Apr 22, 2024
@nastasha-solomon
Copy link
Contributor

Copy has been merged via elastic/kibana#180929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine ui-copy v8.14.0
Projects
None yet
Development

No branches or pull requests

4 participants