-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Fixes the problem with Discover and queries without the from command #180692
[ES|QL] Fixes the problem with Discover and queries without the from command #180692
Conversation
/ci |
let's be sure to align, since now we have 2 similar solutions #179020 |
I didn't see Matt's PR tbh, I think it will still have the @timestamp error I mention here It seems that it was created 3 weeks ago but didnt finish. Is there any particular reason? It seems that we are at the same track though, I am also fixing the aforementioned bug though. Is there any problem on moving on with this PR? I am expecting multiple users to use the ROW command, I don't want to have this bug before GA. Update: On. second glance without testing his PR, I think he doesnt have the bug either. So let's proceed with one of the PRs but please let's merge it on 8.14 🙏 (I like my extra check, why search on the fields when we know that for empty string it won't have the field?) |
yes, I've tested with both PRs and both fix the problem 🎉 ... the extra check makes sense IMO, but can also be added to the other PR for sure |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
I am a bit confused with this
I am opening the PR for review! |
@stratoula Go ahead and grab the functional test from my PR - #179020 |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good and work well!
Summary
Closes #163417
When there was no from command in the query we were using the current dataview. This might have the @timestamp field which is not returned by the
ROW ...
orShow meta
commands. So the histogram was failing.I am solving this issue by creating a dataview based on the current dataview but without the timeFieldName
I still think we should find another way to deal with these commands but for now this is a nice way forward
Before:
Checklist