-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESQL] Support commands which dont need an index #163417
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
This is causing the bug Lukas mention here #173913 (comment) |
We now don't return empty results but the user might encounter this bug if their previous index had the @timestamp column. |
@mattkime @stratoula we should align here, because @mattkime is working on this: #179020 |
I want this to be merged before the FF, I don't want to go GA with this bug folks. I haven't tested Matt's PR tbh. My PR is fixing this #180692 (unless I have missed something) |
For sure! We will definitely not let this 🐛 to escape into the wilderness! |
…command (#180692) ## Summary Closes #163417 When there was no from command in the query we were using the current dataview. This might have the @timestamp field which is not returned by the `ROW ...` or `Show meta` commands. So the histogram was failing. I am solving this issue by creating a dataview based on the current dataview but without the timeFieldName <img width="1677" alt="image" src="https://github.com/elastic/kibana/assets/17003240/81b79634-8c2e-4346-bd34-48ae7580ab89"> I still think we should find another way to deal with these commands but for now this is a nice way forward **Before:** <img width="1679" alt="image" src="https://github.com/elastic/kibana/assets/17003240/68ec6f76-6721-472b-8b49-7c719ad04208"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Describe the feature:
In ESQL we have 2 source commands:
ROW a = 1, b = "two", c = null
) where you can create a test dataset on your ownThe first one creates succesfully an adhoc dataview and works great with Discover.
The second one no. The problem is here where we are creating a dataview with an empty name which Discover considers it invalid. As a result it renders an empty view.
We would like dataviews to also take under consideration this command. Another example is the show command.
For example:
show functions
. This also returns a datatable such asThe text was updated successfully, but these errors were encountered: