Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Unskip Synthetics Serverless Enablement API tests #180199

Conversation

justinkambic
Copy link
Contributor

Summary

Fixes #180108.

Previously these tests failed against MKI. This should resolve the problem as we're no longer trying to use system_indices_superuser, which doesn't exist in MKI environments.

@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0 labels Apr 5, 2024
@justinkambic justinkambic self-assigned this Apr 5, 2024
@justinkambic justinkambic requested a review from a team as a code owner April 5, 2024 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@justinkambic justinkambic force-pushed the 180180/unskip-synthetics-serverless-enablement-api-test-suite branch from 2b21c62 to 7cafcb8 Compare April 5, 2024 14:59
@justinkambic justinkambic changed the title [Synthetics] Unskip synthetics Serverless Enablement API tests [Synthetics] Unskip Synthetics Serverless Enablement API tests Apr 5, 2024
@justinkambic justinkambic enabled auto-merge (squash) April 5, 2024 15:19
@justinkambic justinkambic disabled auto-merge April 5, 2024 17:51
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Ran the suite against an MKI project and it's passing now ✔️

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🚀 Thanks for the fix!

@justinkambic justinkambic enabled auto-merge (squash) April 8, 2024 14:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit c51354f into elastic:main Apr 8, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 8, 2024
@justinkambic justinkambic deleted the 180180/unskip-synthetics-serverless-enablement-api-test-suite branch April 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0
Projects
None yet
7 participants