Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAILS ON MKI] Serverless Observability API Integration Tests.x-pack/test_serverless/api_integration/test_suites/observability/synthetics/synthetics_enablement·ts #180108

Closed
wayneseymour opened this issue Apr 5, 2024 · 3 comments · Fixed by #180199
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@wayneseymour
Copy link
Member

A test suite failes on true serverless (MKI), but not on stateful. It was added as a part of #179861

[00:00:00]  
[00:00:00]   └-: Serverless observability API
[00:00:00]     └-> "before all" hook: beforeTestSuite.trigger in "Serverless observability API"
[00:01:45]     └-: Synthetics API Tests
[00:01:45]       └-> "before all" hook: beforeTestSuite.trigger in "Synthetics API Tests"
[00:01:45]       └-> "before all" hook in "Synthetics API Tests"
[00:01:45]         │ debg No indices to delete [pattern=heartbeat*]
[00:01:45]         │ debg No indices to delete [pattern=synthetics*]
[00:01:45]       └-: SyntheticsEnablement
[00:01:45]         └-> "before all" hook: beforeTestSuite.trigger in "SyntheticsEnablement"
[00:01:45]         └-> "before all" hook in "SyntheticsEnablement"
[00:02:21]         └-: [DELETE] /internal/uptime/service/enablement
[00:02:21]           └-> "before all" hook: beforeTestSuite.trigger for "admin can delete api key"
[00:02:21]           └-> admin can delete api key
[00:02:21]             └-> "before each" hook: global before each for "admin can delete api key"
[00:02:21]             └-> "before each" hook for "admin can delete api key"
[00:02:22]               │ debg new cloud SAML authentication with 'system_indices_superuser' role
[00:02:22]               └- ✖ fail: Serverless observability API Synthetics API Tests SyntheticsEnablement [DELETE] /internal/uptime/service/enablement "before each" hook for "admin can delete api key"
[00:02:22]               │      Error: User with 'system_indices_superuser' role is not defined
[00:02:22]               │       at SamlSessionManager.getCloudUserByRole (session_manager.ts:87:13)
[00:02:22]               │       at SamlSessionManager.getSessionByRole (session_manager.ts:110:40)
[00:02:22]               │       at processTicksAndRejections (node:internal/process/task_queues:95:5)
[00:02:22]               │       at SamlSessionManager.getApiCredentialsForRole (session_manager.ts:135:21)
@wayneseymour wayneseymour added bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Apr 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

wayneseymour added a commit to wayneseymour/kibana that referenced this issue Apr 5, 2024
@pheyos
Copy link
Member

pheyos commented Apr 5, 2024

Note that the system_indices_superuser is not available in a real serverless project on MKI. The test should be refactored (if possible) to not require this role. Otherwise, it will never be able to run on MKI and should be tagged with skipMKI.

wayneseymour added a commit that referenced this issue Apr 5, 2024
## Summary

Skip "SyntheticsEnablement" for mki runs

Details about the failure in
#180108

---------

Co-authored-by: Kibana Machine <[email protected]>
@justinkambic
Copy link
Contributor

I've refactored the test suite here: #180199.

Sorry for the hiccup, future tests will not use this role!

justinkambic added a commit that referenced this issue Apr 8, 2024
## Summary

Fixes #180108.

Previously these tests failed against MKI. This should resolve the
problem as we're no longer trying to use `system_indices_superuser`,
which doesn't exist in MKI environments.
@wayneseymour wayneseymour changed the title failsOnMKI: Serverless Observability API Integration Tests.x-pack/test_serverless/api_integration/test_suites/observability/synthetics/synthetics_enablement·ts [FAILS ON MKI] Serverless Observability API Integration Tests.x-pack/test_serverless/api_integration/test_suites/observability/synthetics/synthetics_enablement·ts May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants