-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Embeddable rebuild] Allow Dashboard to provide references #176455
[Embeddable rebuild] Allow Dashboard to provide references #176455
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
/ci |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the field list embeddable is a nice addition to the examples. Its complex enough to have a linked data view but simple enough that the code can easily be followed.
code review and tested in chrome
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…76455) Adds the ability for the Dashboard to provide references for its React Embeddable children to inject, and adds the ability for the React Embeddable children to provide extracted references back to the Dashboard.
…76455) Adds the ability for the Dashboard to provide references for its React Embeddable children to inject, and adds the ability for the React Embeddable children to provide extracted references back to the Dashboard.
Summary
This PR fixes #176229 by adding the ability for the Dashboard to provide references for its React Embeddable children to inject, and adding the ability for the React Embeddable children to provide extracted references back to the Dashboard.
Also adds a Field List React embeddable example which references a selected Data view. This can be used to test the behaviours of this PR.
How to test
yarn start --run-examples
.Field List
embeddable.unsaved changes
.