Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddable rebuild] Allow Dashboard to provide references #176455

Merged

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Feb 7, 2024

Summary

This PR fixes #176229 by adding the ability for the Dashboard to provide references for its React Embeddable children to inject, and adding the ability for the React Embeddable children to provide extracted references back to the Dashboard.

Also adds a Field List React embeddable example which references a selected Data view. This can be used to test the behaviours of this PR.

Field List

How to test

  • run Kibana with yarn start --run-examples.
  • Create a Dashboard and add a Field List embeddable.
  • Select a data view
  • Save the Dashboard
  • In the saved object management page, ensure the Dashboard has a reference to the selected Data view.
  • Open the Dashboard, ensuring that the data view is properly injected, and that there are no unsaved changes.
Screenshot 2024-02-08 at 12 45 39 PM

@ThomThomson ThomThomson changed the title [Embeddable rebuild] [Embeddable rebuild] Allow Dashboard to provide references Feb 7, 2024
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Embeddables Relating to the Embeddable system release_note:skip Skip the PR/issue when compiling release notes labels Feb 8, 2024
@ThomThomson ThomThomson marked this pull request as ready for review February 8, 2024 17:46
@ThomThomson ThomThomson requested a review from a team as a code owner February 8, 2024 17:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

/ci

@nreese nreese self-requested a review February 12, 2024 14:34
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the field list embeddable is a nice addition to the examples. Its complex enough to have a linked data view but simple enough that the code can easily be followed.
code review and tested in chrome

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 12, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 382.9KB 383.6KB +755.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 36.9KB 37.1KB +229.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 6827db4 into elastic:main Feb 12, 2024
16 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 12, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…76455)

Adds the ability for the Dashboard to provide references for its React Embeddable children to inject, and adds the ability for the React Embeddable children to provide extracted references back to the Dashboard.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…76455)

Adds the ability for the Dashboard to provide references for its React Embeddable children to inject, and adds the ability for the React Embeddable children to provide extracted references back to the Dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embeddable Rebuild] Allow Dashboard to provide references for panels
5 participants