Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] Allow Dashboard to provide references for panels #176229

Closed
Tracked by #167429
ThomThomson opened this issue Feb 5, 2024 · 0 comments · Fixed by #176455
Closed
Tracked by #167429

[Embeddable Rebuild] Allow Dashboard to provide references for panels #176229

ThomThomson opened this issue Feb 5, 2024 · 0 comments · Fixed by #176455
Assignees
@ThomThomson
Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Feb 5, 2024 •
edited
Loading

Problem

The new React Embeddable registry added in #176018 requires references to be tracked in a slightly different way.

The old system required a registry of extract and inject functions which were run all as one process when the Dashboard extract and inject functions ran (on save, and when the Dashboard is loaded respectively).

This new system has no separate inject / extract function requirements, instead, references are passed in when the raw state is deserialized.

Dashboard should have logic that keeps references around long enough to be injected by the new Embeddable system.
@ThomThomson ThomThomson mentioned this issue Feb 5, 2024
Open
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 5, 2024
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Feb 5, 2024
@ThomThomson ThomThomson self-assigned this Feb 5, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 5, 2024
@ThomThomson ThomThomson mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable rebuild] Allow Dashboard to provide references ThomThomson/kibana
1 participant
@ThomThomson