[ML] Adds grok highlighting to the file data visualizer #175913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
jgowdyelastic
commented
Feb 5, 2024
..._visualizer/public/application/file_data_visualizer/components/file_contents/field_badge.tsx
Show resolved
Hide resolved
|
/ci |
qn895
reviewed
Feb 5, 2024
qn895
reviewed
Feb 5, 2024
..._visualizer/public/application/file_data_visualizer/components/results_view/results_view.tsx
Outdated
Show resolved
Hide resolved
peteharverson
changed the title
peteharverson
changed the title
peteharverson
changed the title
szabosteve
reviewed
Feb 6, 2024
There was a problem hiding this comment.
I left an alternative solution for the label strings. It would be interesting to know your opinions as naming is tricky. Thanks in advance! @jgowdyelastic, @peteharverson
...isualizer/public/application/file_data_visualizer/components/file_contents/file_contents.tsx
Outdated
Show resolved
Hide resolved
...isualizer/public/application/file_data_visualizer/components/file_contents/file_contents.tsx
Outdated
Show resolved
Hide resolved
peteharverson
approved these changes
Feb 6, 2024
…sualizer/components/file_contents/file_contents.tsx Co-authored-by: István Zoltán Szabó <[email protected]>
qn895
reviewed
Feb 7, 2024
x-pack/test/functional/apps/ml/data_visualizer/file_data_visualizer.ts
Outdated
Show resolved
Hide resolved
qn895
approved these changes
Feb 7, 2024
|
LGTM, left a note about test data that was commented out. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 8, 2024
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type.  If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type.  If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type.  If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds grokpattern highlighting to the file data visualizer for semi-structured text files.
The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type.
If for whatever reason the highlighting fails, we switch back to the raw text.
@szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs,
Highlighted textandRaw text. So suggestions are welcome.Relates to elastic/elasticsearch#104394