-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint to test Grok pattern #104394
Endpoint to test Grok pattern #104394
Conversation
Pinging @elastic/ml-core (Team:ML) |
Hi @jan-elastic, I've created a changelog YAML for you. |
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Show resolved
Hide resolved
2ba3cd4
to
d0768a4
Compare
4e7ffab
to
83db25c
Compare
314fc1b
to
5d16a04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's on the right track.
I left some minor comments, and also we still have the open question about how variable the response format should be.
rest-api-spec/src/main/resources/rest-api-spec/api/text_structure.test_grok_pattern.json
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Show resolved
Hide resolved
...ain/java/org/elasticsearch/xpack/textstructure/transport/TransportTestGrokPatternAction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/textstructure/action/TestGrokPatternAction.java
Outdated
Show resolved
Hide resolved
@elastic/es-data-management this PR changes the |
...ture/src/main/java/org/elasticsearch/xpack/textstructure/rest/RestTestGrokPatternAction.java
Show resolved
Hide resolved
Co-authored-by: István Zoltán Szabó <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for shepherding the docs, LGTM!
Misc tidy-up following elastic#104394: - This action only runs on the coordinating node, no need to define wire serialization for its request/response types. - No need to subclass `ActionType`, nor to define how to receive responses from remote clusters. - Moves to executing an `AbstractRunnable` to be sure to handle all failures (including threadpool rejections) properly.
Misc tidy-up following #104394: - This action only runs on the coordinating node, no need to define wire serialization for its request/response types. - No need to subclass `ActionType`, nor to define how to receive responses from remote clusters. - Moves to executing an `AbstractRunnable` to be sure to handle all failures (including threadpool rejections) properly.
Misc tidy-up following elastic#104394: - This action only runs on the coordinating node, no need to define wire serialization for its request/response types. - No need to subclass `ActionType`, nor to define how to receive responses from remote clusters. - Moves to executing an `AbstractRunnable` to be sure to handle all failures (including threadpool rejections) properly.
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type. ![image](https://github.com/elastic/kibana/assets/22172091/7b50aeca-0255-4413-93ef-e44976e798f4) If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type. ![image](https://github.com/elastic/kibana/assets/22172091/7b50aeca-0255-4413-93ef-e44976e798f4) If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type. ![image](https://github.com/elastic/kibana/assets/22172091/7b50aeca-0255-4413-93ef-e44976e798f4) If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
Adds grokpattern highlighting to the file data visualizer for semi-structured text files. The first 5 lines of the file are displayed with inline highlighting. Hovering the mouse over displays a tooltip with the field name and type. ![image](https://github.com/elastic/kibana/assets/22172091/7b50aeca-0255-4413-93ef-e44976e798f4) If for whatever reason the highlighting fails, we switch back to the raw text. @szabosteve and @peteharverson I'm not 100% happy with the labels on the tabs, `Highlighted text` and `Raw text`. So suggestions are welcome. Relates to elastic/elasticsearch#104394 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
Example use:
Response: