Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] allow clearing version combo #175322

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Jan 23, 2024

Summary

Closes #175294

Allow clearing upgrade version combo, added validation to highlight that version is required.
Clearing is allowed with backspace or clear button.
Invalid state goes away when selecting a version from the list or typing a custom version.

Single agent upgrade:
image

Bulk agent upgrade:
image

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 23, 2024
@juliaElastic juliaElastic self-assigned this Jan 23, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner January 23, 2024 15:32
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +330.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 4704007 into elastic:main Jan 24, 2024
18 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 24, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Closes elastic#175294

Allow clearing upgrade version combo, added validation to highlight that
version is required.
Clearing is allowed with backspace or clear button.
Invalid state goes away when selecting a version from the list or typing
a custom version.

Single agent upgrade:
<img width="819" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/434301d8-ee2b-4641-8405-a4a673c2eeb6">

Bulk agent upgrade:
<img width="782" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/08a12742-2093-42e6-b6cf-8ed5467a7e70">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Agent Version is not getting removed under Agent upgrade flyout.
6 participants