-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] allow clearing version combo #175322
Merged
juliaElastic
merged 3 commits into
elastic:main
from
juliaElastic:clear-upgrade-version
Jan 24, 2024
Merged
[Fleet] allow clearing version combo #175322
juliaElastic
merged 3 commits into
elastic:main
from
juliaElastic:clear-upgrade-version
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jan 23, 2024
botelastic
bot
added
the
Team:Fleet
Team label for Observability Data Collection Fleet team
label
Jan 23, 2024
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
approved these changes
Jan 23, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
This commit does not require backporting
labels
Jan 24, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Closes elastic#175294 Allow clearing upgrade version combo, added validation to highlight that version is required. Clearing is allowed with backspace or clear button. Invalid state goes away when selecting a version from the list or typing a custom version. Single agent upgrade: <img width="819" alt="image" src="https://github.com/elastic/kibana/assets/90178898/434301d8-ee2b-4641-8405-a4a673c2eeb6"> Bulk agent upgrade: <img width="782" alt="image" src="https://github.com/elastic/kibana/assets/90178898/08a12742-2093-42e6-b6cf-8ed5467a7e70"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #175294
Allow clearing upgrade version combo, added validation to highlight that version is required.
Clearing is allowed with backspace or clear button.
Invalid state goes away when selecting a version from the list or typing a custom version.
Single agent upgrade:
Bulk agent upgrade:
Checklist