Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Agent Version is not getting removed under Agent upgrade flyout. #175294

Closed
harshitgupta-qasource opened this issue Jan 23, 2024 · 4 comments · Fixed by #175322
Closed

[Fleet] Agent Version is not getting removed under Agent upgrade flyout. #175294

harshitgupta-qasource opened this issue Jan 23, 2024 · 4 comments · Fixed by #175322
Assignees
@juliaElastic
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@harshitgupta-qasource
Copy link

Kibana Build details:

VERSION: 8.13.0 SNAPSHOT
BUILD: 70749
COMMIT: a0f4897f7c04069faf2a86dbda1dabea78c161c1

Host OS and Browser version: All, All

Preconditions:

  1. 8.13.0-SNAPSHOT Kibana Cloud environment should be available.
  2. Policy should be created.
  3. 8.11.4 windows agent should be installed.

Steps to reproduce:

  1. Navigate to Fleet>Agents tab and click Upgrade agent.
  2. Observe 8.12.0 version is available.
  3. Then try to remove Agent version using Backspace.
  4. Observe that Agent Version is not getting removed.

Expected:
User should be able to remove Agent Version under Agent upgrade flyout.

Screencast:

Agents.-.Fleet.-.Elastic.Mozilla.Firefox.2024-01-23.16-45-46.mp4
@harshitgupta-qasource harshitgupta-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jan 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@harshitgupta-qasource
Copy link
Author

@amolnater-qasource Kindly review

@amolnater-qasource
Copy link

Secondary Review for this ticket is Done.

@juliaElastic juliaElastic self-assigned this Jan 23, 2024
@juliaElastic juliaElastic mentioned this issue Jan 23, 2024
Merged
2 tasks
juliaElastic added a commit that referenced this issue Jan 24, 2024
@juliaElastic
[Fleet] allow clearing version combo (#175322)
4704007 
## Summary

Closes #175294

Allow clearing upgrade version combo, added validation to highlight that
version is required.
Clearing is allowed with backspace or clear button.
Invalid state goes away when selecting a version from the list or typing
a custom version.

Single agent upgrade:
<img width="819" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/434301d8-ee2b-4641-8405-a4a673c2eeb6">

Bulk agent upgrade:
<img width="782" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/08a12742-2093-42e6-b6cf-8ed5467a7e70">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 24, 2024
@amolnater-qasource
Copy link

Hi Team,

We have revalidated this issue on latest 8.13.0 SNAPSHOT kibana cloud environment and found it fixed now.

Observations:

  • User is now able to remove Agent Version under Agent upgrade flyout.

Build details:
VERSION: 8.13.0 SNAPSHOT
BUILD: 71297
COMMIT: 099e2d4

Screen Recording :

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2024-02-05.16-12-21.mp4

Hence we are marking this issue as QA:Validated.

Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 5, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@juliaElastic @CoenWarmer
[Fleet] allow clearing version combo (elastic#175322)
30c1d3f 
## Summary

Closes elastic#175294

Allow clearing upgrade version combo, added validation to highlight that
version is required.
Clearing is allowed with backspace or clear button.
Invalid state goes away when selecting a version from the list or typing
a custom version.

Single agent upgrade:
<img width="819" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/434301d8-ee2b-4641-8405-a4a673c2eeb6">

Bulk agent upgrade:
<img width="782" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/08a12742-2093-42e6-b6cf-8ed5467a7e70">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliaElastic juliaElastic

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] allow clearing version combo juliaElastic/kibana
4 participants
@elasticmachine @amolnater-qasource @juliaElastic @harshitgupta-qasource