Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Fix text alignment of options list control selections #175073

Merged
merged 7 commits into from
Jan 30, 2024
Merged

[Controls] Fix text alignment of options list control selections #175073

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cec2be9
Fix alignment issues
Heenawter Jan 17, 2024
286f1a1
Merge branch 'main' into fix-control-styling_2024-01-17
Heenawter Jan 18, 2024
5f4a38b
Merge branch 'main' into fix-control-styling_2024-01-17
Heenawter Jan 22, 2024
fed1b70
Merge branch 'main' into fix-control-styling_2024-01-17
Heenawter Jan 24, 2024
28489cf
Merge branch 'main' into fix-control-styling_2024-01-17
Heenawter Jan 24, 2024
f1ee5ad
Remove targeting of EUI class
Heenawter Jan 26, 2024
c545674
Merge branch 'main' into fix-control-styling_2024-01-17
Heenawter Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/plugins/controls/public/options_list/components/options_list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@
color: $euiColorDanger;
}

.euiFilterButton__text-hasNotification {
flex-grow: 1;
justify-content: space-between;
width: 0;
.euiFilterButton__text {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a custom class as opposed to overriding .euiFilterButton__text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍 That should hopefully prevent these types of bugs in the future. Done in f1ee5ad

text-align: left;

&-hasNotification {
flex-grow: 1;
}
}
}

Expand Down