[Controls] Fix text alignment of options list control selections #175073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
bug
|
/ci |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
added
the
release_note:skip
ryankeairns
reviewed
Jan 26, 2024
| flex-grow: 1; | ||
| justify-content: space-between; | ||
| width: 0; | ||
| .euiFilterButton__text { |
There was a problem hiding this comment.
Is it possible to add a custom class as opposed to overriding .euiFilterButton__text?
There was a problem hiding this comment.
Good call 👍 That should hopefully prevent these types of bugs in the future. Done in f1ee5ad
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Heenawter |
ryankeairns
approved these changes
Jan 30, 2024
Heenawter
added
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…stic#175073) Closes elastic#174971 ## Summary This PR fixes the alignment issue for the options list control that happened due to the most recent EUI update. | Before | After | |--------|--------| |  |  | ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…stic#175073) Closes elastic#174971 ## Summary This PR fixes the alignment issue for the options list control that happened due to the most recent EUI update. | Before | After | |--------|--------| |  |  | ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174971
Summary
This PR fixes the alignment issue for the options list control that happened due to the most recent EUI update.
Checklist
For maintainers