Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Enabling and Removing alertsPreviewChartEmbeddablesEnabled feature flag #173884

Merged
merged 16 commits into from
Jan 12, 2024
Merged

[SecuritySolution] Enabling and Removing alertsPreviewChartEmbeddablesEnabled feature flag #173884

merged 16 commits into from
Jan 12, 2024

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 21, 2023 •
edited
Loading

Summary

This PR is a part of #171287, the final goal is to remove chartEmbeddablesEnabled feature flag

  1. Enabling and removing alertsPreviewChartEmbeddablesEnabled feature flag (It's unblocked by [Security Solution] Custom dashboard UI prerequisite #136409 item 9)
  2. Replacing rules preview histogram with Lens Embeddable.
Screen.Recording.2024-01-09.at.18.04.49.mov

Screenshot 2024-01-02 at 21 47 39

Screenshot 2024-01-09 at 02 18 37

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc mentioned this pull request Dec 21, 2023
Closed
3 tasks
@angorayc
Copy link
Contributor Author

angorayc commented Jan 2, 2024

buildkite test this

@angorayc
Copy link
Contributor Author

angorayc commented Jan 5, 2024

buildkite test this

@angorayc
Copy link
Contributor Author

angorayc commented Jan 8, 2024

buildkite test this

@angorayc angorayc changed the title remove alertsPreviewChartEmbeddablesEnabled feature flag [SecuritySolution] Enabling and Removing alertsPreviewChartEmbeddablesEnabled feature flag Jan 9, 2024
@angorayc
Copy link
Contributor Author

angorayc commented Jan 9, 2024

buildkite test this

@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.13.0 backport:skip This commit does not require backporting Feature:Lens Charts Security Solution Lens Charts feature labels Jan 9, 2024
@angorayc angorayc self-assigned this Jan 9, 2024
@angorayc angorayc marked this pull request as ready for review January 9, 2024 16:07
@angorayc angorayc requested review from a team as code owners January 9, 2024 16:07
@angorayc angorayc requested a review from a team as a code owner January 9, 2024 16:07
@angorayc angorayc requested a review from yctercero January 9, 2024 16:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

stephmilovic
stephmilovic approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing and all looks good. Nice work! My only comment is about adding a check for length on responses. Please fix that before merging and LGTM!

e40pud
e40pud approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DE changes LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / [ESS] Save Timeline Prompts "before each" hook for "should prompt when navigating with a changed & unsaved timeline within security solution where timelines are disabled eg. admin screen" "before each" hook for "should prompt when navigating with a changed & unsaved timeline within security solution where timelines are disabled eg. admin screen"
  • [job] [logs] FTR Configs #61 / management creating and deleting default data view edit index pattern on edit click

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4870 4871 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.3MB -8.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 65.3KB 65.3KB -40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@angorayc angorayc merged commit fe57319 into elastic:main Jan 12, 2024
40 checks passed
@banderror banderror mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@e40pud e40pud e40pud approved these changes

@yctercero yctercero Awaiting requested review from yctercero yctercero was automatically assigned from elastic/security-detection-engine

Assignees

@angorayc angorayc

Labels
backport:skip This commit does not require backporting Feature:Lens Charts Security Solution Lens Charts feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@angorayc @elasticmachine @kibana-ci @e40pud @stephmilovic @kibanamachine