Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Remove the unused code for histograms and charts in SecuritySolution #171287

Closed
3 tasks done
angorayc opened this issue Nov 15, 2023 · 2 comments
Closed
3 tasks done

[SecuritySolution] Remove the unused code for histograms and charts in SecuritySolution #171287

angorayc opened this issue Nov 15, 2023 · 2 comments
Assignees
@angorayc
Labels
Feature:Lens Charts Security Solution Lens Charts feature Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@angorayc
Copy link
Contributor

angorayc commented Nov 15, 2023 •
edited
Loading

We have GA Lens Embeddables in Security Solution.
Now we could safely remove the chartEmbeddablesEnabled feature flag.
@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Feature:Lens Charts Security Solution Lens Charts feature labels Nov 15, 2023
@angorayc angorayc self-assigned this Nov 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

This was referenced Dec 19, 2023
Merged
Merged
@angorayc angorayc mentioned this issue Jan 11, 2024
Closed
10 tasks
angorayc added a commit that referenced this issue Jan 12, 2024
@angorayc @kibanamachine
[SecuritySolution] Enabling and Removing alertsPreviewChartEmbeddable…
fe57319 
…sEnabled feature flag (#173884)

## Summary

This PR is a part of #171287,
the final goal is to remove `chartEmbeddablesEnabled` feature flag
1. Enabling and removing **alertsPreviewChartEmbeddablesEnabled**
feature flag (It's unblocked by
#136409 item 9)
2. Replacing **rules preview** histogram with Lens Embeddable.



https://github.com/elastic/kibana/assets/6295984/c29aa600-c86b-4d32-933b-4d8f6f1fd04f



![Screenshot 2024-01-02 at 21 47
39](https://github.com/elastic/kibana/assets/6295984/300b1357-12fe-4601-b4c2-0c97cc5d5bba)

![Screenshot 2024-01-09 at 02 18
37](https://github.com/elastic/kibana/assets/6295984/832bbb04-477e-4c71-8589-4cec19da5c6e)

### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
Feature:Lens Charts Security Solution Lens Charts feature Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angorayc @elasticmachine