Require page reload when changing timepicker:quickRanges
#173747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
Dosant
added
the
release_note:skip
jughosta
approved these changes
Dec 20, 2023
|
Can we backport? |
Dosant
added
the
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2023
…73747) ## Summary fix elastic#172601 I reviewed how this setting is used. It is directly used in a lot of places and it is hard to guarantee/fix that all places pick up the new setting. Safer to ask to reload. (cherry picked from commit 36c9d5d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2023
…73747) (#173767) # Backport This will backport the following commits from `main` to `8.12`: - [Require page reload when changing `timepicker:quickRanges` (#173747)](#173747) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-20T16:15:54Z","message":"Require page reload when changing `timepicker:quickRanges` (#173747)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/172601\r\n\r\nI reviewed how this setting is used. It is directly used in a lot of\r\nplaces and it is hard to guarantee/fix that all places pick up the new\r\nsetting. Safer to ask to reload.","sha":"36c9d5dd3dd51f70c8d38a0a28e5ddb59d8520d7","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.13.0"],"number":173747,"url":"https://github.com/elastic/kibana/pull/173747","mergeCommit":{"message":"Require page reload when changing `timepicker:quickRanges` (#173747)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/172601\r\n\r\nI reviewed how this setting is used. It is directly used in a lot of\r\nplaces and it is hard to guarantee/fix that all places pick up the new\r\nsetting. Safer to ask to reload.","sha":"36c9d5dd3dd51f70c8d38a0a28e5ddb59d8520d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173747","number":173747,"mergeCommit":{"message":"Require page reload when changing `timepicker:quickRanges` (#173747)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/172601\r\n\r\nI reviewed how this setting is used. It is directly used in a lot of\r\nplaces and it is hard to guarantee/fix that all places pick up the new\r\nsetting. Safer to ask to reload.","sha":"36c9d5dd3dd51f70c8d38a0a28e5ddb59d8520d7"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #172601
I reviewed how this setting is used. It is directly used in a lot of places and it is hard to guarantee/fix that all places pick up the new setting. Safer to ask to reload.