Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Skip flaky Rule Management tests #173730

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Dec 20, 2023

Resolves: #173469

Summary

This PR:

  • Skips flaky Rule Management tests that occurred recently and haven't been already skipped by Kibana Operations.
  • Adds TODO comments with links to the corresponding tickets.

We will be working on fixing and unskipping these and a few other tests in January as part of #173731.

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror force-pushed the skip-flaky-rule-management-tests branch from a0c72d5 to 3328109 Compare December 20, 2023 13:27
@banderror banderror requested review from dplumlee and removed request for jpdjere December 20, 2023 13:28
@banderror banderror added the release_note:skip Skip the PR/issue when compiling release notes label Dec 20, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Timeline Discover ESQL State "before each" hook for "should remember esql query when navigating away and back to discover " "before each" hook for "should remember esql query when navigating away and back to discover "

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit cdb1047 into elastic:main Dec 20, 2023
44 checks passed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 20, 2023
**Resolves: elastic#173469

## Summary

This PR:

- Skips flaky Rule Management tests that occurred recently and haven't
been already skipped by Kibana Operations.
- Adds `TODO` comments with links to the corresponding tickets.

We will be working on fixing and unskipping these and a few other tests
in January as part of elastic#173731.

(cherry picked from commit cdb1047)
@banderror banderror deleted the skip-flaky-rule-management-tests branch December 20, 2023 15:25
kibanamachine added a commit that referenced this pull request Dec 20, 2023
…#173759)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution] Skip flaky Rule Management tests
(#173730)](#173730)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-20T15:18:21Z","message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","test-failure-flaky","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","v8.12.0","v8.13.0"],"number":173730,"url":"https://github.com/elastic/kibana/pull/173730","mergeCommit":{"message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173730","number":173730,"mergeCommit":{"message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7"}}]}]
BACKPORT-->

Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test test-failure-flaky v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Triage and skip new flakes in Rule Management tests
5 participants