Skip to content

Commit

Permalink
[8.12] [Security Solution] Skip flaky Rule Management tests (#173730) (
Browse files Browse the repository at this point in the history
…#173759)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution] Skip flaky Rule Management tests
(#173730)](#173730)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-20T15:18:21Z","message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","test-failure-flaky","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","v8.12.0","v8.13.0"],"number":173730,"url":"https://github.com/elastic/kibana/pull/173730","mergeCommit":{"message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173730","number":173730,"mergeCommit":{"message":"[Security
Solution] Skip flaky Rule Management tests (#173730)\n\n**Resolves:
https://github.com/elastic/kibana/issues/173469**\r\n\r\n##
Summary\r\n\r\nThis PR:\r\n\r\n- Skips flaky Rule Management tests that
occurred recently and haven't\r\nbeen already skipped by Kibana
Operations.\r\n- Adds `TODO` comments with links to the corresponding
tickets.\r\n\r\nWe will be working on fixing and unskipping these and a
few other tests\r\nin January as part of
https://github.com/elastic/kibana/issues/173731.","sha":"cdb10478ce1270e8ce0ec37ddff98888e92f0af7"}}]}]
BACKPORT-->

Co-authored-by: Georgii Gorbachev <[email protected]>
  • Loading branch information
kibanamachine and banderror authored Dec 20, 2023
1 parent c6dc1b8 commit cf47748
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ export default ({ getService }: FtrProviderContext): void => {
* Unlike other tests that use mocks, this test uses actual rules from the
* package storage and checks that they are installed.
*/
it('should install prebuilt rules from the package storage', async () => {
// TODO: Fix and unskip https://github.com/elastic/kibana/issues/172107
it.skip('should install prebuilt rules from the package storage', async () => {
// Verify that status is empty before package installation
const statusBeforePackageInstallation = await getPrebuiltRulesAndTimelinesStatus(supertest);
expect(statusBeforePackageInstallation.rules_installed).toBe(0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const ruleNameToAssert = 'Custom rule name with actions';
const expectedExistingSlackMessage = 'Existing slack action';
const expectedSlackMessage = 'Slack action test message';

// TODO: Fix and unskip in Serverless https://github.com/elastic/kibana/issues/171101
describe(
'Detection rules, bulk edit of rule actions',
{ tags: ['@ess', '@serverless', '@brokenInServerless', '@brokenInServerlessQA'] },
Expand Down

0 comments on commit cf47748

Please sign in to comment.