Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Fix flaky search or filter tests #173367

Merged
merged 10 commits into from
Dec 14, 2023
Merged

[SecuritySolution] Fix flaky search or filter tests #173367

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b138a02
`trigger('click')` -> `click()`
janmonschke Dec 14, 2023
e4bfd27
checking for existence after clicking does not make sense
janmonschke Dec 14, 2023
b15c9eb
delete timelines
janmonschke Dec 14, 2023
1aa8a5e
unskip test
janmonschke Dec 14, 2023
76af23e
flaky test runner setup
janmonschke Dec 14, 2023
c651b39
Revert "flaky test runner setup"
janmonschke Dec 14, 2023
159fd6e
remove unused tasks and selectors
janmonschke Dec 14, 2023
a60f931
remove { force: true }
janmonschke Dec 14, 2023
581d665
should
janmonschke Dec 14, 2023
76a9814
extract into functions
janmonschke Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...est/security_solution_cypress/cypress/e2e/investigations/timelines/search_or_filter.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ import {
showDataProviderQueryBuilder,
} from '../../../tasks/timeline';
import { waitForTimelinesPanelToBeLoaded } from '../../../tasks/timelines';
import { deleteTimelines } from '../../../tasks/api_calls/common';

import { hostsUrl, TIMELINES_URL } from '../../../urls/navigation';

describe('Timeline search and filters', { tags: ['@ess', '@serverless'] }, () => {
describe('timeline search or filter KQL bar', () => {
beforeEach(() => {
login();
deleteTimelines();
visitWithTimeRange(hostsUrl('allHosts'));
});

PhilippeOberti marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -53,18 +55,17 @@ describe('Timeline search and filters', { tags: ['@ess', '@serverless'] }, () =>
});
PhilippeOberti marked this conversation as resolved.
Show resolved Hide resolved
});

// FLAKY: https://github.com/elastic/kibana/issues/169882
describe.skip('Update kqlMode for timeline', () => {
describe('Update kqlMode for timeline', () => {
beforeEach(() => {
login();
deleteTimelines();
visit(TIMELINES_URL);
waitForTimelinesPanelToBeLoaded();
openTimelineUsingToggle();
cy.intercept('PATCH', '/api/timeline').as('update');
cy.get(LOADING_INDICATOR).should('not.exist');
showDataProviderQueryBuilder();
cy.get(TIMELINE_SEARCH_OR_FILTER).click();
PhilippeOberti marked this conversation as resolved.
Show resolved Hide resolved
cy.get(TIMELINE_SEARCH_OR_FILTER).should('exist');
});

it('should be able to update timeline kqlMode with filter', () => {
PhilippeOberti marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/security_solution_cypress/cypress/tasks/timeline.ts
View file
Open in desktop
PhilippeOberti marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,6 @@ export const openTimelineFromOpenTimelineModal = (timelineName: string) => {

export const showDataProviderQueryBuilder = () => {
cy.get(TOGGLE_DATA_PROVIDER_BTN).should('have.attr', 'aria-pressed', 'false');
cy.get(TOGGLE_DATA_PROVIDER_BTN).trigger('click');
cy.get(TOGGLE_DATA_PROVIDER_BTN).click();
cy.get(TOGGLE_DATA_PROVIDER_BTN).should('have.attr', 'aria-pressed', 'true');
};