Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix flaky search or filter tests #173367

Merged
merged 10 commits into from
Dec 14, 2023
Merged

[SecuritySolution] Fix flaky search or filter tests #173367

merged 10 commits into from
Dec 14, 2023

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Dec 14, 2023 •
edited
Loading

Summary

  • trigger('click') -> click()
  • Removed unnecessary existence check
  • Deleting timelines before each test to ensure they start on a clean slate

Flaky test runner result

fixes #169882, fixes #169032

@janmonschke janmonschke marked this pull request as ready for review December 14, 2023 12:30
@janmonschke janmonschke requested a review from a team as a code owner December 14, 2023 12:30
@janmonschke janmonschke self-assigned this Dec 14, 2023
@janmonschke janmonschke added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels Dec 14, 2023
@janmonschke janmonschke mentioned this pull request Dec 14, 2023
Closed
25 tasks
@janmonschke
Copy link
Contributor Author

/ci

lgestc
lgestc approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

PhilippeOberti
PhilippeOberti requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

...k/test/security_solution_cypress/cypress/e2e/investigations/timelines/search_or_filter.cy.ts Show resolved Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/timelines/search_or_filter.cy.ts Outdated Show resolved Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/timelines/search_or_filter.cy.ts Show resolved Hide resolved
x-pack/test/security_solution_cypress/cypress/tasks/timeline.ts Outdated Show resolved Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/timelines/search_or_filter.cy.ts Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

PhilippeOberti
PhilippeOberti approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks awesome!!

@PhilippeOberti PhilippeOberti merged commit d766ac8 into elastic:main Dec 14, 2023
38 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@lgestc lgestc lgestc approved these changes

Assignees

@janmonschke janmonschke

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.13.0
Projects
None yet
Milestone
No milestone
5 participants
@janmonschke @kibana-ci @lgestc @PhilippeOberti @kibanamachine