Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] [Security Solution][Detections] Flaky alert assignments tests (#173284) #173344

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[8.12] [Security Solution][Detections] Flaky alert assignments tests (#173284) #173344

merged 1 commit into from
Dec 14, 2023

Conversation

yctercero
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@e40pud
[Security Solution][Detections] Flaky alert assignments tests (elasti…
3e21862 
…c#173284)

## Summary

With these changes we fix flaky tests caused by the flakiness of the
alert actions button. There is a [`expandFirstAlertActions`
method](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts#L125)
which workarounds this issue.

### Flaky tests:
1. elastic#172611
2. elastic#172623
3. elastic#172663

### Flaky test runner (100 times)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538
(cherry picked from commit 17bc0c9)

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts
@yctercero yctercero enabled auto-merge (squash) December 14, 2023 01:25
@yctercero yctercero mentioned this pull request Dec 14, 2023
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

e40pud
e40pud approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport! LGTM

@yctercero yctercero merged commit 726025c into elastic:8.12 Dec 14, 2023
40 checks passed
@yctercero yctercero deleted the backport/8.12/pr-173284 branch December 14, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e40pud e40pud e40pud approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yctercero @kibana-ci @e40pud