Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Flaky alert assignments tests #173284

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[Security Solution][Detections] Flaky alert assignments tests #173284

merged 4 commits into from
Dec 13, 2023

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Dec 13, 2023 •
edited
Loading

Summary

With these changes we fix flaky tests caused by the flakiness of the alert actions button. There is a expandFirstAlertActions method which workarounds this issue.

Flaky tests:

  1. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments·cy·ts - Alert user assignment - ESS & Serverless Basic rendering alert with many assignees (collapsed into badge) in alert's details flyout alert with many assignees (collapsed into badge) in alert's details flyout #172611
  2. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments·cy·ts - Alert user assignment - ESS & Serverless Updating assignees (single alert) removing all assignees via More actions in alerts table removing all assignees via More actions in alerts table #172623
  3. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments·cy·ts - Alert user assignment - ESS & Serverless Basic rendering alert with some assignees in alert's details flyout alert with some assignees in alert's details flyout #172663
  4. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments·cy·ts - Alert user assignment - ESS & Serverless Basic rendering alert with many assignees (collapsed into badge) in alerts table alert with many assignees (collapsed into badge) in alerts table #172982

Flaky test runner (100 times)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Detection Engine Security Solution Detection Engine Area labels Dec 13, 2023
@e40pud e40pud self-assigned this Dec 13, 2023
@e40pud e40pud requested a review from a team as a code owner December 13, 2023 14:08
@e40pud e40pud requested a review from nkhristinin December 13, 2023 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud requested a review from yctercero December 13, 2023 14:08
nkhristinin
nkhristinin approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / serverless observability UI Observability Log Explorer Header menu Discover tabs should navigate between discover tabs without keeping the current columns/filters/query/time/data view

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud merged commit 17bc0c9 into elastic:main Dec 13, 2023
39 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.12 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 173284

Questions ?

Please refer to the Backport tool documentation

@yctercero yctercero mentioned this pull request Dec 14, 2023
Merged
@yctercero
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yctercero pushed a commit to yctercero/kibana that referenced this pull request Dec 14, 2023
@e40pud
[Security Solution][Detections] Flaky alert assignments tests (elasti…
3e21862 
…c#173284)

## Summary

With these changes we fix flaky tests caused by the flakiness of the
alert actions button. There is a [`expandFirstAlertActions`
method](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts#L125)
which workarounds this issue.

### Flaky tests:
1. elastic#172611
2. elastic#172623
3. elastic#172663

### Flaky test runner (100 times)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538
(cherry picked from commit 17bc0c9)

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts
yctercero added a commit that referenced this pull request Dec 14, 2023
@yctercero @e40pud
[8.12] [Security Solution][Detections] Flaky alert assignments tests (#…
726025c 
…173284) (#173344)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution][Detections] Flaky alert assignments tests
(#173284)](#173284)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-13T20:56:12Z","message":"[Security
Solution][Detections] Flaky alert assignments tests (#173284)\n\n##
Summary\r\n\r\nWith these changes we fix flaky tests caused by the
flakiness of the\r\nalert actions button. There is a
[`expandFirstAlertActions`\r\nmethod](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts#L125)\r\nwhich
workarounds this issue.\r\n\r\n### Flaky tests:\r\n1.
https://github.com/elastic/kibana/issues/172611\r\n2.
https://github.com/elastic/kibana/issues/172623\r\n3.
https://github.com/elastic/kibana/issues/172663\r\n\r\n### Flaky test
runner (100
times)\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538","sha":"17bc0c9fa2f7a2d5d0f3ff0c71f848686f182373","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","backport:prev-minor","Team:Detection
Engine","v8.13.0"],"number":173284,"url":"https://github.com/elastic/kibana/pull/173284","mergeCommit":{"message":"[Security
Solution][Detections] Flaky alert assignments tests (#173284)\n\n##
Summary\r\n\r\nWith these changes we fix flaky tests caused by the
flakiness of the\r\nalert actions button. There is a
[`expandFirstAlertActions`\r\nmethod](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts#L125)\r\nwhich
workarounds this issue.\r\n\r\n### Flaky tests:\r\n1.
https://github.com/elastic/kibana/issues/172611\r\n2.
https://github.com/elastic/kibana/issues/172623\r\n3.
https://github.com/elastic/kibana/issues/172663\r\n\r\n### Flaky test
runner (100
times)\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538","sha":"17bc0c9fa2f7a2d5d0f3ff0c71f848686f182373"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173284","number":173284,"mergeCommit":{"message":"[Security
Solution][Detections] Flaky alert assignments tests (#173284)\n\n##
Summary\r\n\r\nWith these changes we fix flaky tests caused by the
flakiness of the\r\nalert actions button. There is a
[`expandFirstAlertActions`\r\nmethod](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts#L125)\r\nwhich
workarounds this issue.\r\n\r\n### Flaky tests:\r\n1.
https://github.com/elastic/kibana/issues/172611\r\n2.
https://github.com/elastic/kibana/issues/172623\r\n3.
https://github.com/elastic/kibana/issues/172663\r\n\r\n### Flaky test
runner (100
times)\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4538","sha":"17bc0c9fa2f7a2d5d0f3ff0c71f848686f182373"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
This was referenced Dec 14, 2023
Closed
Closed
Closed
Closed
@e40pud e40pud deleted the security/tests/flaky-alert-assignments branch February 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

@yctercero yctercero Awaiting requested review from yctercero

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@e40pud @elasticmachine @kibana-ci @kibanamachine @yctercero @nkhristinin