Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix get file handler for bundled package (#172182) #173058

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Dec 11, 2023

Summary

Repush #172182 (that was reverted due to memory) consumption issues after fixing getBundledPackages memory issue with a cache in #172640

@nchaulet nchaulet self-assigned this Dec 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet requested a review from kpollich December 11, 2023 13:54
@nchaulet nchaulet marked this pull request as ready for review December 11, 2023 15:29
@nchaulet nchaulet requested a review from a team as a code owner December 11, 2023 15:29
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for repushing this after the memory fixes

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Dec 11, 2023
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit fa3b6f4 into elastic:main Dec 12, 2023
38 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 12, 2023
@nchaulet nchaulet removed the backport:skip This commit does not require backporting label Dec 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 22, 2023
@nchaulet nchaulet added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 22, 2023
@nchaulet
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nchaulet added a commit to nchaulet/kibana that referenced this pull request Dec 22, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 22, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 22, 2023
…73058) (#173912)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Fix get file handler for bundled package (#172182)
(#173058)](#173058)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T16:05:46Z","message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173058,"url":"https://github.com/elastic/kibana/pull/173058","mergeCommit":{"message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173058","number":173058,"mergeCommit":{"message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
nchaulet added a commit that referenced this pull request Dec 22, 2023
…73058) (#173911)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Fix get file handler for bundled package (#172182)
(#173058)](#173058)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T16:05:46Z","message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173058,"url":"https://github.com/elastic/kibana/pull/173058","mergeCommit":{"message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173058","number":173058,"mergeCommit":{"message":"[Fleet]
Fix get file handler for bundled package (#172182)
(#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants