[Fleet] Fix get file handler for bundled package #172182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Nov 29, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
added
v8.12.0
backport:skip
kpollich
added a commit
to kpollich/kibana
that referenced
this pull request
Dec 5, 2023
)" This reverts commit 4d52ad2.
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 5, 2023
)" This reverts commit 4d52ad2.
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 5, 2023
)" This reverts commit 4d52ad2.
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 5, 2023
)" This reverts commit 4d52ad2.
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Dec 11, 2023
nchaulet
added a commit
that referenced
this pull request
Dec 12, 2023
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Dec 22, 2023
…astic#173058) (cherry picked from commit fa3b6f4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 22, 2023
…astic#173058) (cherry picked from commit fa3b6f4)
kibanamachine
added a commit
that referenced
this pull request
Dec 22, 2023
…73058) (#173912) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix get file handler for bundled package (#172182) (#173058)](#173058) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T16:05:46Z","message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173058,"url":"https://github.com/elastic/kibana/pull/173058","mergeCommit":{"message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173058","number":173058,"mergeCommit":{"message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
nchaulet
added a commit
that referenced
this pull request
Dec 22, 2023
…73058) (#173911) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix get file handler for bundled package (#172182) (#173058)](#173058) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T16:05:46Z","message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173058,"url":"https://github.com/elastic/kibana/pull/173058","mergeCommit":{"message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173058","number":173058,"mergeCommit":{"message":"[Fleet] Fix get file handler for bundled package (#172182) (#173058)","sha":"fa3b6f4c9da88e6ddbd1fae7c502d00353c55134"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #166045
That PR allow to retrieve files for bundled package that are not installed, this allow to display the APM integration on premise
Before that change
After
Manual tests instructions
Configure kibana to use those bundled packages
xpack.fleet.developer.bundledPackageLocation: /tmp/test-8.11/kibana-8.11.1/node_modules/@kbn/fleet-plugin/target/bundled_packagesNavigate to apm and check the integration is displayed http://localhost:5601/app/integrations/detail/apm/overview
Todo