Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security/APIKey Service] Internal API endpoint do determine if user has API keys #172884
[Security/APIKey Service] Internal API endpoint do determine if user has API keys #172884
Changes from 3 commits
24b53e9
b730c9f
89a92fd
a469842
1a332f6
9fd5b10
bdf8987
09496b5
c0fb932
f39999c
598f141
5b51b06
474ed25
83ea4c9
423037a
c1aeb86
27a823a
eeb8e10
7640ed4
d15c932
c6461cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the
owner
field needs any conditions, but perhaps I'm not aware.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not aware of any conditions either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: you filter out invalidated keys, but not expired ones - is it intentional? If not, can we use
active_only
request parameter to avoid this additional filtering?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azasypkin I see your point, but I don't see the
active_only
parameter supported in theSecurityGetApiKeyRequest
typings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it should be available since 8.10.0 - elastic/elasticsearch#98259 - let me figure this out. In the worst case I'd prefer to do something like this to filter keys on ES side instead:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we'll get this definition in the client soon (elastic/elasticsearch#103621), let's move forward with
active_only
and@ts-expect-error
(if needed) for now (Client will include the parameter regardless wrong type definition).