-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add active_only
flag to Get API Key REST spec
#103621
Add active_only
flag to Get API Key REST spec
#103621
Conversation
active_only
flag to Get API key rest specactive_only
flag to Get API Key REST spec
@elastic/clients-team we introduced this change back in 8.10 -- do we have an approach for backporting this kind of change to older versions of ES? I can add older ES version labels (for 8.10 and 8.11) just want to make sure that's appropriate, given that we are generally backporting to those branches anymore. Thanks and sorry about the hassle 🙏 |
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would it make sense to add a YAML test for active_only
flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@elasticmachine update branch |
@elasticmachine update branch |
elastic#98259 added a new flag for the Get API key API. I missed adding it to the REST API spec originally. This PR corrects the REST spec.
💚 Backport successful
|
#98259 added a new flag for the Get API key API. I missed adding it to the REST API spec originally. This PR corrects the REST spec. Co-authored-by: Elastic Machine <[email protected]>
elastic#98259 added a new flag for the Get API key API. I missed adding it to the REST API spec originally. This PR corrects the REST spec.
#98259 added a new flag for the Get API key API. I missed adding it to the REST API spec originally.
This PR corrects the REST spec.