Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active_only flag to Get API Key REST spec #103621

Merged

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Dec 20, 2023

#98259 added a new flag for the Get API key API. I missed adding it to the REST API spec originally.

This PR corrects the REST spec.

@n1v0lg n1v0lg added >non-issue :Security/Security Security issues without another label Team:Clients Meta label for clients team labels Dec 20, 2023
@n1v0lg n1v0lg self-assigned this Dec 20, 2023
@n1v0lg n1v0lg added auto-backport Automatically create backport pull requests when merged v8.11.4 labels Dec 20, 2023
@n1v0lg n1v0lg added v8.12.1 and removed v8.11.4 labels Dec 20, 2023
@n1v0lg n1v0lg changed the title Add active_only flag to Get API key rest spec Add active_only flag to Get API Key REST spec Dec 20, 2023
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Dec 20, 2023

@elastic/clients-team we introduced this change back in 8.10 -- do we have an approach for backporting this kind of change to older versions of ES? I can add older ES version labels (for 8.10 and 8.11) just want to make sure that's appropriate, given that we are generally backporting to those branches anymore. Thanks and sorry about the hassle 🙏

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine elasticsearchmachine removed the Team:Clients Meta label for clients team label Dec 20, 2023
@n1v0lg n1v0lg added the Team:Clients Meta label for clients team label Dec 20, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Clients Meta label for clients team label Dec 20, 2023
Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would it make sense to add a YAML test for active_only flag?

Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Dec 21, 2023

@elasticmachine update branch

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Dec 21, 2023

@elasticmachine update branch

@n1v0lg n1v0lg added test-update-serverless auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Dec 21, 2023
@elasticsearchmachine elasticsearchmachine merged commit 512aff5 into elastic:main Dec 21, 2023
19 checks passed
@n1v0lg n1v0lg deleted the fix/get-api-keyactive-only-flag-spec branch December 21, 2023 10:52
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Dec 21, 2023
elastic#98259 added a new flag for
the Get API key API. I missed adding it to the REST API spec originally.


This PR corrects the REST spec.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.12

elasticsearchmachine pushed a commit that referenced this pull request Dec 21, 2023
#98259 added a new flag for
the Get API key API. I missed adding it to the REST API spec originally.


This PR corrects the REST spec.

Co-authored-by: Elastic Machine <[email protected]>
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 22, 2023
elastic#98259 added a new flag for
the Get API key API. I missed adding it to the REST API spec originally.


This PR corrects the REST spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team test-update-serverless v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants