Deprecate feature flag for Log threshold alert details page #172554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
benakansara
changed the title
jbudz
reviewed
Dec 5, 2023
src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
Outdated
Show resolved
Hide resolved
|
(removed review request for @elastic/kibana-security as it's no longer required after 114fcf4) |
x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @benakansara |
I had removed it before and got this failure: https://buildkite.com/elastic/kibana-pull-request/builds/181747#018c3a00-ef61-4dc0-84a2-53b96c9671c7 I added it back because we are not removing the feature flag from config, but deprecating it. This should be removed when the flag is removed from the config in future. |
maryam-saeidi
approved these changes
Dec 7, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
…172554) Resolves elastic#172379 - Deprecates following feature flag used for enabling/disabling Log threshold alert details page: ``` xpack.observability.unsafe.alertDetails.logs.enabled ``` - Removes usage of this flag from code. - Adding this flag in `kibana.yml` will generate following warning: ``` [WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.logs.enabled". ``` --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 6628232)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
…172554) (#172775) # Backport This will backport the following commits from `main` to `8.12`: - [Deprecate feature flag for Log threshold alert details page (#172554)](#172554) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T07:35:01Z","message":"Deprecate feature flag for Log threshold alert details page (#172554)\n\nResolves https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates following feature flag used for enabling/disabling Log\r\nthreshold alert details page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172554,"url":"https://github.com/elastic/kibana/pull/172554","mergeCommit":{"message":"Deprecate feature flag for Log threshold alert details page (#172554)\n\nResolves https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates following feature flag used for enabling/disabling Log\r\nthreshold alert details page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172554","number":172554,"mergeCommit":{"message":"Deprecate feature flag for Log threshold alert details page (#172554)\n\nResolves https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates following feature flag used for enabling/disabling Log\r\nthreshold alert details page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #172379
kibana.ymlwill generate following warning: