remove feature flag usage from tests

elastic · Dec 5, 2023 · 658a30e · 658a30e
1 parent 562b538
commit 658a30e
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 25 deletions.
diff --git a/x-pack/plugins/observability/public/application/application.test.tsx b/x-pack/plugins/observability/public/application/application.test.tsx
@@ -75,7 +75,6 @@ describe('renderApp', () => {
   const config = {
     unsafe: {
       alertDetails: {
-        logs: { enabled: false },
         metrics: { enabled: false },
         uptime: { enabled: false },
       },

diff --git a/x-pack/plugins/observability/public/pages/alert_details/alert_details.test.tsx b/x-pack/plugins/observability/public/pages/alert_details/alert_details.test.tsx
@@ -90,7 +90,6 @@ const params = {
 const config: Subset<ConfigSchema> = {
   unsafe: {
     alertDetails: {
-      logs: { enabled: true },
       metrics: { enabled: true },
       uptime: { enabled: true },
     },

diff --git a/x-pack/plugins/observability/public/pages/alerts/components/alert_actions.test.tsx b/x-pack/plugins/observability/public/pages/alerts/components/alert_actions.test.tsx
@@ -53,7 +53,6 @@ jest.mock('@kbn/triggers-actions-ui-plugin/public/common/lib/kibana/kibana_react
 const config = {
   unsafe: {
     alertDetails: {
-      logs: { enabled: false },
       metrics: { enabled: false },
       uptime: { enabled: false },
     },

diff --git a/.../plugins/observability/public/pages/overview/components/sections/apm/apm_section.test.tsx b/.../plugins/observability/public/pages/overview/components/sections/apm/apm_section.test.tsx
@@ -48,7 +48,6 @@ describe('APMSection', () => {
     const config = {
       unsafe: {
         alertDetails: {
-          logs: { enabled: false },
           metrics: { enabled: false },
           uptime: { enabled: false },
         },

diff --git a/x-pack/plugins/observability/public/pages/overview/overview.stories.tsx b/x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
@@ -78,17 +78,16 @@ const withCore = makeDecorator({
       },
     } as unknown as Partial<CoreStart>);
 
-    const config: ConfigSchema = {
+    const config = {
       unsafe: {
         alertDetails: {
-          logs: { enabled: false },
           metrics: { enabled: false },
           uptime: { enabled: false },
           observability: { enabled: false },
         },
         thresholdRule: { enabled: false },
       },
-    };
+    } as ConfigSchema;
 
     return (
       <MemoryRouter>

diff --git a/x-pack/plugins/observability/public/utils/is_alert_details_enabled.test.ts b/x-pack/plugins/observability/public/utils/is_alert_details_enabled.test.ts
@@ -31,7 +31,6 @@ import type { TopAlert } from '../typings/alerts';
 const defaultConfig = {
   unsafe: {
     alertDetails: {
-      logs: { enabled: false },
       metrics: { enabled: false },
       uptime: { enabled: false },
     },
@@ -63,15 +62,10 @@ describe('isAlertDetailsEnabled', () => {
       start: 1630587249674,
       lastUpdated: 1630588131750,
     } as unknown as TopAlert;
-    it('returns FALSE when logs: { enabled: false }', () => {
-      expect(isAlertDetailsEnabledPerApp(logsAlert, defaultConfig)).toBeFalsy();
-    });
-
-    it('returns TRUE when logs: { enabled: true }', () => {
+    it('returns TRUE when rule type is logs.alert.document.count', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: true },
             metrics: { enabled: false },
             uptime: { enabled: false },
           },
@@ -113,7 +107,6 @@ describe('isAlertDetailsEnabled', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: false },
             metrics: { enabled: false },
             uptime: { enabled: false },
           },
@@ -159,7 +152,6 @@ describe('isAlertDetailsEnabled', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: false },
             metrics: { enabled: true },
             uptime: { enabled: false },
           },
@@ -201,7 +193,6 @@ describe('isAlertDetailsEnabled', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: false },
             metrics: { enabled: false },
             uptime: { enabled: true },
           },
@@ -243,7 +234,6 @@ describe('isAlertDetailsEnabled', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: true },
             metrics: { enabled: true },
             uptime: { enabled: true },
           },
@@ -255,7 +245,6 @@ describe('isAlertDetailsEnabled', () => {
       const updatedConfig = {
         unsafe: {
           alertDetails: {
-            logs: { enabled: true },
             metrics: { enabled: true },
             uptime: { enabled: true },
           },

diff --git a/x-pack/plugins/observability/public/utils/kibana_react.storybook_decorator.tsx b/x-pack/plugins/observability/public/utils/kibana_react.storybook_decorator.tsx
@@ -25,17 +25,16 @@ export function KibanaReactStorybookDecorator(Story: ComponentType) {
   } as unknown as AppMountParameters;
   const observabilityRuleTypeRegistry = createObservabilityRuleTypeRegistryMock();
 
-  const config: ConfigSchema = {
+  const config = {
     unsafe: {
       alertDetails: {
-        logs: { enabled: false },
         metrics: { enabled: false },
         uptime: { enabled: false },
         observability: { enabled: false },
       },
       thresholdRule: { enabled: false },
     },
-  };
+  } as ConfigSchema;
 
   const mockTheme: CoreTheme = {
     darkMode: false,

diff --git a/x-pack/plugins/observability/public/utils/test_helper.tsx b/x-pack/plugins/observability/public/utils/test_helper.tsx
@@ -29,17 +29,16 @@ const observabilityRuleTypeRegistry = createObservabilityRuleTypeRegistryMock();
 export const core = coreMock.createStart();
 export const data = dataPluginMock.createStartContract();
 
-const defaultConfig: ConfigSchema = {
+const defaultConfig = {
   unsafe: {
     alertDetails: {
-      logs: { enabled: false },
       metrics: { enabled: false },
       uptime: { enabled: false },
       observability: { enabled: false },
     },
     thresholdRule: { enabled: false },
   },
-};
+} as ConfigSchema;
 
 const queryClient = new QueryClient({
   defaultOptions: {