Upgrade EUI to v90.0.1 #172261
Upgrade EUI to v90.0.1 #172261
Conversation
- save me Sebastian! - component was updated to use an ExclusiveUnion and not accept both `href/linkProps` or `items/accordionProps` etc - going to leave as-is for now as I'm not confident in my ability to not break code, and the component should handle excess props gracefully
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
| @@ -290,6 +290,7 @@ const nodeToEuiCollapsibleNavProps = ( | |||
| } | |||
|
|
|||
| const items: Array<EuiCollapsibleNavItemProps | EuiCollapsibleNavSubItemPropsEnhanced> = [ | |||
| // @ts-ignore - TODO | |||
There was a problem hiding this comment.
@sebelga Apologies for these TODOs for you/your team - I briefly (5-15 minutes) spiked out resolving the Typescript errors, but it involved removing several props and I was not confident that I was doing it correctly.
Unfortunately the EUI team doesn't have bandwidth right now to correctly address this before 8.12FF, so I thought I'd just get in the component changes sooner and have you take a look at the type reconciliation later.
FWIW, the type was updated in elastic/eui#7337 to use an ExclusiveUnion and not accept either href/linkProps or items/accordionProps/isCollapsed, but not both.
The type errors do not affect actual production behavior, the component handles excess props gracefully and does not pass href down to accordions or groups with items.
There was a problem hiding this comment.
Ok no worries, I'll fix the type in a separate PR 👍
cee-chen
added
release_note:skip
|
Pinging @elastic/eui-team (EUI) |
| @@ -290,6 +290,7 @@ const nodeToEuiCollapsibleNavProps = ( | |||
| } | |||
|
|
|||
| const items: Array<EuiCollapsibleNavItemProps | EuiCollapsibleNavSubItemPropsEnhanced> = [ | |||
| // @ts-ignore - TODO | |||
There was a problem hiding this comment.
Ok no worries, I'll fix the type in a separate PR 👍
`v90.0.1`⏩`v90.0.1-backport.0` Backport/bugfix for #172261 --- ## [`v90.0.1-backport.0`](https://github.com/elastic/eui/releases/v90.0.1-backport.0) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed a bug with `EuiSelectable`s with custom `truncationProps`, where scrollbar widths were not being accounted for ([#7392](elastic/eui#7392))
v90.0.0⏩v90.0.1This release also contains updates to EuiCollapsibleNavBeta, to support serverless UX (elastic/eui#7337).
90.0.1This release is a backport intended for Kibana 8.12.
EuiSelectablenow allows configurable text truncation vialistProps.truncationProps(#7388)EuiTextTruncatenow supports a newcalculationDelayMsprop for working around font loading or layout shifting scenarios (#7388)