Add Mock IDP login page and role switcher #172257

thomheymann · 2023-11-30T09:11:49Z

Follow up to #170852

Summary

Adds login page and role switcher for development-only identity provider.

Screenshots

Login page

Role switcher

Testing

SAML is only supported by ES when running in SSL mode.

To test the mock identity provider run a serverless project in SSL mode using:

yarn es serverless --ssl
yarn start --serverless=es --ssl

Then access Kibana and login in using "Continue as Test User".

…fix'

…heymann/kibana into serverless-role-selector-ui

…fix'

…heymann/kibana into serverless-role-selector-ui

…fix'

…heymann/kibana into serverless-role-selector-ui

…ess-role-selector-ui

pgayvallet · 2023-12-01T09:02:49Z

packages/core/http/core-http-resources-server/src/types.ts

+  /**
+   * To respond with HTML page bootstrapping Kibana application without retrieving user-specific information.
+   * **Note:**
+   * - Your client-side JavaScript bundle will only be loaded on an anonymous page if `plugin.enabledOnAnonymousPages` is enabled in your plugin's `kibana.jsonc` manifest file.
+   * - You will also need to register the route serving your anonymous app with the `coreSetup.http.anonymousPaths` service in your plugin's client-side `setup` method.
+   * */


I can feel the pain and suffering in this comment addition 😄

jbudz · 2023-12-01T12:50:50Z

packages/kbn-optimizer/limits.yml

@@ -97,6 +97,7 @@ pageLoadAssetSize:
  mapsEms: 26072
  metricsDataAccess: 73287
  ml: 82187
+  mockIdpPlugin: 30000


Mind if we add a ci:cloud-deploy label? This seems like a gap in the packaging system with a development plugin included in production.

I can see we're skipping the server load but I'm not sure how the client is going to behave.

Oh..it's not a development plugin but it's pulling in mock-idp-utils which is devOnly. Can you help me understand the workflow in production?

@jbudz Both plugins are development-only and are not used in production. The only reason they're broken up into two separate plugins is to avoid cyclic TS projects.

Can we add devOnly to https://github.com/elastic/kibana/pull/172257/files#diff-04504e6ebadd3cdc5ecb3ff8e4e2aa2d793812f94fbe64f727b2a4b3fcb79a66R6

Both plugins already have devOnly enabled:

https://github.com/elastic/kibana/pull/172257/files#diff-04504e6ebadd3cdc5ecb3ff8e4e2aa2d793812f94fbe64f727b2a4b3fcb79a66L5

https://github.com/elastic/kibana/pull/172257/files#diff-776e20a48718f6a26de3c35a65c305b1b1f4b4e16576e4328842d4f04a80343bR5

Is something not working as expected?

Is opts.dev enabled for these QA cloud deployments?

It's not. We're using the same build script we use for releases, i.e. the node scripts/build --release

@pgayvallet Is there any other mechanism in place where Kibana would load in this plugin despite the dev CLI arg not being set?

@thomheymann I apologize, I missed the ping. We have one CI script (the SO schema check) that loads Kibana while forcing all plugins to be enabled. but I don't think it would be the issue here.

However, fwiw, I'm not sure the optimizer / bundler ever supported evicting "devOnly" plugins @jbudz?

Having the plugin disabled in production for sure. Not bundling specific plugins into the distributable? AFAIK this was never implemented. I think the bundler will consider all plugins as production code?

Looking at your PR and at the @kbn/mock-idp-plugin, I'm not sure how we got to the conclusion that this plugin is disabled by default and/or not bundled for production?

The plugin discovery system is now plugged on the package list, so it's not because a plugin in under package instead of /src/plugins or /x-pack/plugins that it will be disabled by default. All packages with a kibana.jsonc file will be considered as a plugin and included in the plugin list automatically (and then loaded).

Also IIRC, the bundler will consider all plugins as production code, meaning that they WILL be included (ignoring, I assume, the devOnly flag that is supposed to work on packages, not plugins)

@jbudz will have to confirm those assumptions of course, bundling/bazel is Operations' territory, not Core's. But if that was the case, the only approach I would think of is to add a configuration to your plugin with a schema forcing it to be disabled for production, like

enabled: schema.conditional( schema.contextRef('dist'), true, schema.boolean({ defaultValue: false, validate: (raw) => { if(raw !== false) { throw "mock idp plugin cannot be enabled in production"} } }), schema.boolean({ defaultValue: true }) ),

However, fwiw, I'm not sure the optimizer / bundler ever supported evicting "devOnly" plugins @jbudz?

It's safe to ignore any of my assumptions here. I haven't really been involved with any of the packaging changes. @mistic do you know?

…ess-role-selector-ui

…fix'

jbudz · 2023-12-01T19:41:13Z

buildkite test this

azasypkin · 2024-01-11T12:01:06Z

@elastic/kibana-operations @elastic/kibana-qa @elastic/kibana-security PR is ready for your review!

## Summary Both cloud and serverless deployments of elastic#172257 are failing. These are small additions to help investigation, or fix potential errors.

azasypkin · 2024-01-11T13:54:24Z

src/dev/build/tasks/build_packages_task.ts

@@ -255,7 +255,7 @@ export const BuildPackages: Task = {
              Path.resolve(pkgDistPath, 'package-map.json'),
              JSON.stringify(
                packages
-                  .filter((p) => p.isPlugin())
+                  .filter((p) => p.isPlugin() && !p.isDevOnly())


note: without this change, @kbn/mock-idp-plugin (dev-only) is included into package-map.json even though it's not actually bundled into the build. Let me know if you have any better ideas how to solve this!

Is this not going to interfere with other builds?
Is it related to this thread: #172257 (comment)?

@mistic , do you have any opinions on this?

@azasypkin I suggest we change that line https://github.com/elastic/kibana/blob/main/src/dev/build/lib/config.ts#L249 with (!p.isPlugin() || (this.pluginFilter(p) && !p.isDevOnly())) instead of adding the check on this line

Sure, @mistic, thanks! Applied your suggestion in f979aa7.

dmlemeshko

Code LGTM. Tested locally for all the projects, works perfectly.

delanni

Ops related changes 👍

mistic · 2024-01-12T18:47:25Z

src/dev/build/tasks/build_packages_task.ts

@@ -255,7 +255,7 @@ export const BuildPackages: Task = {
              Path.resolve(pkgDistPath, 'package-map.json'),
              JSON.stringify(
                packages
-                  .filter((p) => p.isPlugin())
+                  .filter((p) => p.isPlugin() && !p.isDevOnly())


Suggested change

.filter((p) => p.isPlugin() && !p.isDevOnly())

.filter((p) => p.isPlugin())

kibana-ci · 2024-01-12T20:04:50Z

💔 Build Failed

Buildkite Build
Commit: f979aa7
Interpreting CI Failures
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-172257-f979aa7a006f
Elasticsearch Serverless Deployment

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #24 / Detection Engine API - Update Prebuilt Rules Package @ess @serverless @skipInQA update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`mockIdpPlugin`	-	43	+43

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/mock-idp-utils`	-	18	+18
`mockIdpPlugin`	19	2	-17
total			+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`mockIdpPlugin`	-	27.8KB	+27.8KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5724	+5724
`total size`	-	6.0MB	+6.0MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`mockIdpPlugin`	-	12.2KB	+12.2KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/mock-idp-utils`	-	25	+25
`mockIdpPlugin`	25	2	-23
total			+2

async chunk count

id	before	after	diff
`mockIdpPlugin`	-	1	+1

ESLint disabled line counts

id	before	after	diff
`mockIdpPlugin`	0	1	+1

Total ESLint disabled count

id	before	after	diff
`mockIdpPlugin`	0	1	+1

History

💛 Build #186957 was flaky eaba0ef
💔 Build #186952 failed ae6aabf
💛 Build #186223 was flaky b9a3298
💔 Build #186212 failed b9a3298

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

legrego · 2024-01-13T14:21:15Z

Resolves #166340

thomheymann and others added 17 commits November 30, 2023 09:08

Add Mock IDP login page and role switcher

92686f3

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

f1eb108

…fix'

Separate mock IDP package

f0a38eb

Merge branch 'serverless-role-selector-ui' of https://github.com/thom…

58e2e2b

…heymann/kibana into serverless-role-selector-ui

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

eb34508

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

f1d598f

Update limits

2e47f43

Merge branch 'serverless-role-selector-ui' of https://github.com/thom…

a704a2d

…heymann/kibana into serverless-role-selector-ui

Remove translations

75755eb

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

a458759

…fix'

Fix plugin path

0501827

Merge branch 'serverless-role-selector-ui' of https://github.com/thom…

84d52cd

…heymann/kibana into serverless-role-selector-ui

Fix snapshot test

f2c74a1

Fix offset

40259a9

Merge branch 'main' of https://github.com/elastic/kibana into serverl…

848ec7c

…ess-role-selector-ui

Fix application usage test

d6a7623

.

0da9c1c

thomheymann marked this pull request as ready for review November 30, 2023 23:58

thomheymann requested review from a team as code owners November 30, 2023 23:58

thomheymann added the release_note:skip Skip the PR/issue when compiling release notes label Dec 1, 2023

pgayvallet approved these changes Dec 1, 2023

View reviewed changes

jbudz reviewed Dec 1, 2023

View reviewed changes

thomheymann and others added 3 commits December 1, 2023 16:10

Only show relevant roles

3e2ed38

Merge branch 'main' of https://github.com/elastic/kibana into serverl…

15ee54a

…ess-role-selector-ui

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

86827f2

…fix'

thomheymann added the ci:cloud-deploy Create or update a Cloud deployment label Dec 1, 2023

azasypkin added ci:cloud-redeploy Always create a new Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels Jan 11, 2024

azasypkin added 3 commits January 11, 2024 11:39

Merge branch 'main' into pr-172257-mock-idp

4239759

A few minor tweaks.

ae6aabf

Few more tweaks.

eaba0ef

azasypkin requested a review from a team January 11, 2024 11:55

delanni added a commit to delanni/kibana that referenced this pull request Jan 11, 2024

Deployment investigations (elastic#174345)

2650803

## Summary Both cloud and serverless deployments of elastic#172257 are failing. These are small additions to help investigation, or fix potential errors.

azasypkin reviewed Jan 11, 2024

View reviewed changes

dmlemeshko approved these changes Jan 12, 2024

View reviewed changes

delanni approved these changes Jan 12, 2024

View reviewed changes

azasypkin requested a review from a team January 12, 2024 12:24

azasypkin mentioned this pull request Jan 12, 2024

[kbn-es] move svl roles definition to separate files & start servers accordingly #174284

Merged

Merge branch 'main' into pr-172257-mock-idp

a5a08e2

SiddharthMantri approved these changes Jan 12, 2024

View reviewed changes

mistic reviewed Jan 12, 2024

View reviewed changes

azasypkin added 2 commits January 12, 2024 21:20

Merge branch 'main' into pr-172257-mock-idp

8294235

Review#1: move isDevOnly check to getDistPackagesFromRepo.

f979aa7

azasypkin removed ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels Jan 12, 2024

azasypkin merged commit 7bee86d into elastic:main Jan 12, 2024
37 of 38 checks passed

kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 12, 2024

legrego mentioned this pull request Jan 13, 2024

Implement a SAML role(s) selector to aid developers in testing Serverless Kibana with different user privileges #166340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Mock IDP login page and role switcher #172257

Add Mock IDP login page and role switcher #172257

thomheymann commented Nov 30, 2023 •

edited

Loading

pgayvallet Dec 1, 2023

jbudz Dec 1, 2023

jbudz Dec 1, 2023

thomheymann Dec 1, 2023

jbudz Dec 1, 2023

thomheymann Dec 1, 2023

jbudz Dec 4, 2023

thomheymann Dec 5, 2023

pgayvallet Dec 13, 2023

pgayvallet Dec 13, 2023 •

edited

Loading

jbudz Dec 13, 2023

jbudz commented Dec 1, 2023

azasypkin commented Jan 11, 2024

azasypkin Jan 11, 2024

delanni Jan 12, 2024

mistic Jan 12, 2024

azasypkin Jan 12, 2024 •

edited

Loading

dmlemeshko left a comment

delanni left a comment

mistic Jan 12, 2024

kibana-ci commented Jan 12, 2024 •

edited

Loading

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

legrego commented Jan 13, 2024

	.filter((p) => p.isPlugin() && !p.isDevOnly())
	.filter((p) => p.isPlugin())

Add Mock IDP login page and role switcher #172257

Add Mock IDP login page and role switcher #172257

Conversation

thomheymann commented Nov 30, 2023 • edited Loading

Summary

Screenshots

Login page

Role switcher

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet Dec 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbudz commented Dec 1, 2023

azasypkin commented Jan 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azasypkin Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

delanni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Jan 12, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Canvas Sharable Runtime

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

legrego commented Jan 13, 2024

thomheymann commented Nov 30, 2023 •

edited

Loading

pgayvallet Dec 13, 2023 •

edited

Loading

azasypkin Jan 12, 2024 •

edited

Loading

kibana-ci commented Jan 12, 2024 •

edited

Loading