Review#1: move isDevOnly check to getDistPackagesFromRepo.

elastic · Jan 12, 2024 · f979aa7 · f979aa7
1 parent 8294235
commit f979aa7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/dev/build/lib/config.ts b/src/dev/build/lib/config.ts
@@ -246,7 +246,7 @@ export class Config {
     return getPackages(this.repoRoot).filter(
       (p) =>
         (this.pluginSelector.testPlugins || !p.isDevOnly()) &&
-        (!p.isPlugin() || this.pluginFilter(p))
+        (!p.isPlugin() || (this.pluginFilter(p) && !p.isDevOnly()))
     );
   }
 

diff --git a/src/dev/build/tasks/build_packages_task.ts b/src/dev/build/tasks/build_packages_task.ts
@@ -255,7 +255,7 @@ export const BuildPackages: Task = {
               Path.resolve(pkgDistPath, 'package-map.json'),
               JSON.stringify(
                 packages
-                  .filter((p) => p.isPlugin() && !p.isDevOnly())
+                  .filter((p) => p.isPlugin())
                   .map((p) => [p.manifest.id, `node_modules/${p.manifest.id}`])
               )
             );