[UnifiedDocViewer] Implement floating actions #171365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Team:DataDiscovery
lukasolson
changed the title
davismcphee
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Looks and works great! Definitely allows the doc viewer to make better use of the available space. A couple initial points of feedback:
- I noticed that currently the floating actions aren't keyboard accessible, and the focus just skips over the whole table. I debugged this a bit and found that removing the
visibilityCSS styles fromkbnDocViewer__buttonsfixed the issue and still seemed to work as intended, but maybe there's another reason these are needed. - I'd recommend we remove the
iconSize="s"fromtable_cell_actions.tsxsince the icons currently are a bit small compared to the mockups. - I found the slower hover leave transition looked a bit strange (laggy maybe?) when moving the cursor over multiple rows. I see there's a comment about using a slower transition on hover leave in case the user accidentally stops hovering, but personally I find it looks better and functions just as well using
$euiAnimSpeedFastfor both transitions.
Yeah, unfortunately the suggested fix introduces its own set of strange behavior (can't copy the field name). I think @kertal had suggested something as well, but now I'm coming to a blank on what it was - Do you remember Matthias? |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @lukasolson |
Hmm, I don't remember I had a valid suggestion, maybe it comes to my mind when out of planning mode 😃 |
|
Closing as we are considering using cell actions & data grid here instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #164617.
Before:
Before.mov
After:
After.mov
Checklist