Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDocViewer] Use the floating actions and get rid of that empty space on the left #164617

Closed
Tracked by #163284
kertal opened this issue Aug 23, 2023 · 2 comments
Closed
Tracked by #163284

[UnifiedDocViewer] Use the floating actions and get rid of that empty space on the left #164617

kertal opened this issue Aug 23, 2023 · 2 comments
Assignees
@lukasolson
Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Aug 23, 2023

For desktop, remove the Actions column. Instead, use the floating actions we introduced for Controls. These floating actions should appear on the left side of the row. For small screens where hover is unavailable, we can fallback to the current implementation.
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 23, 2023
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Aug 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the Feature:UnifiedDocViewer Issues relating to the unified doc viewer component label Aug 23, 2023
@kertal kertal added the enhancement New value added to drive a business result label Aug 23, 2023
@kertal kertal mentioned this issue Aug 23, 2023
Closed
@davismcphee davismcphee added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 8, 2023
@andreadelrio andreadelrio mentioned this issue Oct 2, 2023
Merged
2 tasks
@lukasolson lukasolson mentioned this issue Nov 15, 2023
Closed
6 tasks
@kertal
Copy link
Member Author

kertal commented Jan 18, 2024

Closing since we decided not to continue but evaluate EuiDataGrid for the Component make use of its Cell actions

@kertal kertal closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedDocViewer] Implement floating actions lukasolson/kibana
4 participants
@kertal @lukasolson @elasticmachine @davismcphee