Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [RAM][Bug] Fix bug preventing filters from being added to conditional actions (#171048) #171362

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

JiaweiWu
Copy link
Contributor

Backport

This will backport the following commits from main to 8.11:

Questions ?

Please refer to the Backport tool documentation

… actions (elastic#171048)

## Summary
Resolves: elastic#171036

Fixes a bug where the schema name for the conditional action filter
`$state` was incorrectly name. This prevented the user from adding
filters to conditional actions as the schema validation would reject the
request.

### To verify the fix:

1. Create a rule
2. Add a conditional action
3. Assert that filters can be added to the rule
4. Rule is saved
5. Repeat 1 - 4 but this time, update the rule.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit fbb2328)

# Conflicts:
#	x-pack/plugins/alerting/common/routes/rule/apis/create/schemas/v1.ts
#	x-pack/plugins/alerting/common/routes/rule/common/index.ts
#	x-pack/plugins/alerting/common/routes/rule/response/schemas/v1.ts
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu JiaweiWu merged commit 46e0cda into elastic:8.11 Nov 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants