[RAM][Bug] Alerts search bar cannot save query with filter #171036
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
JiaweiWu
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
1 task
github-project-automation
bot
moved this from In Progress
to Done
in AppEx: ResponseOps - Rules & Alerts Management
JiaweiWu
added a commit
that referenced
this issue
Nov 15, 2023
… actions (#171048) ## Summary Resolves: #171036 Fixes a bug where the schema name for the conditional action filter `$state` was incorrectly name. This prevented the user from adding filters to conditional actions as the schema validation would reject the request. ### To verify the fix: 1. Create a rule 2. Add a conditional action 3. Assert that filters can be added to the rule 4. Rule is saved 5. Repeat 1 - 4 but this time, update the rule. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>
JiaweiWu
added a commit
to JiaweiWu/kibana
that referenced
this issue
Nov 15, 2023
… actions (elastic#171048) ## Summary Resolves: elastic#171036 Fixes a bug where the schema name for the conditional action filter `$state` was incorrectly name. This prevented the user from adding filters to conditional actions as the schema validation would reject the request. ### To verify the fix: 1. Create a rule 2. Add a conditional action 3. Assert that filters can be added to the rule 4. Rule is saved 5. Repeat 1 - 4 but this time, update the rule. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit fbb2328) # Conflicts: # x-pack/plugins/alerting/common/routes/rule/apis/create/schemas/v1.ts # x-pack/plugins/alerting/common/routes/rule/common/index.ts # x-pack/plugins/alerting/common/routes/rule/response/schemas/v1.ts
JiaweiWu
added a commit
to JiaweiWu/kibana
that referenced
this issue
Nov 15, 2023
… actions (elastic#171048) ## Summary Resolves: elastic#171036 Fixes a bug where the schema name for the conditional action filter `$state` was incorrectly name. This prevented the user from adding filters to conditional actions as the schema validation would reject the request. ### To verify the fix: 1. Create a rule 2. Add a conditional action 3. Assert that filters can be added to the rule 4. Rule is saved 5. Repeat 1 - 4 but this time, update the rule. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit fbb2328) # Conflicts: # x-pack/plugins/alerting/common/routes/rule/apis/create/schemas/v1.ts # x-pack/plugins/alerting/common/routes/rule/common/index.ts # x-pack/plugins/alerting/common/routes/rule/response/schemas/v1.ts
JiaweiWu
added a commit
to JiaweiWu/kibana
that referenced
this issue
Nov 15, 2023
… actions (elastic#171048) ## Summary Resolves: elastic#171036 Fixes a bug where the schema name for the conditional action filter `$state` was incorrectly name. This prevented the user from adding filters to conditional actions as the schema validation would reject the request. ### To verify the fix: 1. Create a rule 2. Add a conditional action 3. Assert that filters can be added to the rule 4. Rule is saved 5. Repeat 1 - 4 but this time, update the rule. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit fbb2328) # Conflicts: # x-pack/plugins/alerting/common/routes/rule/apis/create/schemas/v1.ts # x-pack/plugins/alerting/common/routes/rule/common/index.ts # x-pack/plugins/alerting/common/routes/rule/response/schemas/v1.ts
JiaweiWu
referenced
this issue
Nov 16, 2023
…itional actions (#171048) (#171362) # Backport This will backport the following commits from `main` to `8.11`: - [[RAM][Bug] Fix bug preventing filters from being added to conditional actions (#171048)](#171048) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-15T19:38:50Z","message":"[RAM][Bug] Fix bug preventing filters from being added to conditional actions (#171048)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/171036\r\n\r\nFixes a bug where the schema name for the conditional action filter\r\n`$state` was incorrectly name. This prevented the user from adding\r\nfilters to conditional actions as the schema validation would reject the\r\nrequest.\r\n\r\n### To verify the fix:\r\n\r\n1. Create a rule\r\n2. Add a conditional action\r\n3. Assert that filters can be added to the rule\r\n4. Rule is saved\r\n5. Repeat 1 - 4 but this time, update the rule. \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fbb232815b85961ac09b6abbe369eb7b3760752d","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.12.0","v8.11.1","v8.10.5"],"number":171048,"url":"https://github.com/elastic/kibana/pull/171048","mergeCommit":{"message":"[RAM][Bug] Fix bug preventing filters from being added to conditional actions (#171048)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/171036\r\n\r\nFixes a bug where the schema name for the conditional action filter\r\n`$state` was incorrectly name. This prevented the user from adding\r\nfilters to conditional actions as the schema validation would reject the\r\nrequest.\r\n\r\n### To verify the fix:\r\n\r\n1. Create a rule\r\n2. Add a conditional action\r\n3. Assert that filters can be added to the rule\r\n4. Rule is saved\r\n5. Repeat 1 - 4 but this time, update the rule. \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fbb232815b85961ac09b6abbe369eb7b3760752d"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171048","number":171048,"mergeCommit":{"message":"[RAM][Bug] Fix bug preventing filters from being added to conditional actions (#171048)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/171036\r\n\r\nFixes a bug where the schema name for the conditional action filter\r\n`$state` was incorrectly name. This prevented the user from adding\r\nfilters to conditional actions as the schema validation would reject the\r\nrequest.\r\n\r\n### To verify the fix:\r\n\r\n1. Create a rule\r\n2. Add a conditional action\r\n3. Assert that filters can be added to the rule\r\n4. Rule is saved\r\n5. Repeat 1 - 4 but this time, update the rule. \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fbb232815b85961ac09b6abbe369eb7b3760752d"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to create a rule with a conditional action. When trying to add a filter and saving the rule, the saving will return a
400.The text was updated successfully, but these errors were encountered: