Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][API testing] Move and restructures Risk Engine tests #170530

Merged
merged 29 commits into from
Nov 9, 2023
Merged

[Security Solution][API testing] Move and restructures Risk Engine tests #170530

merged 29 commits into from
Nov 9, 2023

Conversation

WafaaNasr
Copy link
Contributor

@WafaaNasr WafaaNasr commented Nov 3, 2023 •
edited
Loading

Summary

Following the initial work in this #166755

  • Addresses part of [Security Solution] Restructure API integration tests into meaningful groups that run in parallel on CI #151902 for Entity Analytics/Risk Engine
  • Introduced new folders called entity_analytics/risk_engine under security_solution_api_integration
  • Moved the utility files associated with risk_engine to the new directory security_solution_api_integration. Files that were not actively used in the previous folder were moved, while any duplicate files remained in their original positions.
  • Updated the CodeOwner file for the newly moved tests
  • Old / new groups details and execution time document
Action File New Path if moved
Moved group10/risk_engine/init_and_status_apis /entity_analytics/default_license/risk_engine/init_and_status_apis.ts
Moved group10/risk_engine/risk_score_calculation /entity_analytics/default_license/risk_engine/risk_score_calculation.ts
Moved group10/risk_engine/risk_score_preview /entity_analytics/default_license/risk_engine/risk_score_preview.ts
Moved group10/risk_engine/risk_scoring_task_execution /entity_analytics/default_license/risk_engine/risk_scoring_task_execution.ts
Moved group10/risk_engine/telemetry_usage /entity_analytics/default_license/risk_engine/telemetry_usage.ts
Moved group10/risk_engine/utils entity_analytics/utils/risk_engine.ts
Moved utils/get_stats entity_analytics/utils/get_risk_engine_stats.ts

Tests skipped on main:

https://github.com/elastic/kibana/blob/main/x-pack/test/detection_engine_api_integration/security_and_spaces/group10/risk_engine/init_and_status_apis.ts#L363

@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes FTR labels Nov 3, 2023
@WafaaNasr WafaaNasr self-assigned this Nov 3, 2023
kibanamachine and others added 22 commits November 3, 2023 14:34
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
4bd15a9 
…fix'
@WafaaNasr
revert removing the util
caeba60
@WafaaNasr
Merge branch 'move-structure-risk_engine_apis' of https://github.com/…
9fef0c7 
…WafaaNasr/kibana into move-structure-risk_engine_apis
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
8bc9cd7 
…ructure-risk_engine_apis
@WafaaNasr
fix conflict
40566f7
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
856ce92 
…ructure-risk_engine_apis
@WafaaNasr
add documentations for the new commands in the package.json
1930e93
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
f8b183d 
…ructure-risk_engine_apis
@WafaaNasr
remove @brokenInServerless from risk engine tests
e7b0b5e
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
27b02e4 
…ructure-risk_engine_apis
@WafaaNasr
add rule_execution_logic
e0dc174
@nkhristinin
add header to internal requests
3cfc709
@WafaaNasr
Merge branch 'move-structure-risk_engine_apis' of https://github.com/…
cb796af 
…WafaaNasr/kibana into move-structure-risk_engine_apis
@WafaaNasr
fix conflict
3e82f11
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
aca80b5 
…fix'
@WafaaNasr
remove the rule execution tests
da85cbe
@WafaaNasr
Merge branch 'move-structure-risk_engine_apis' of https://github.com/…
9414252 
…WafaaNasr/kibana into move-structure-risk_engine_apis
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
60bf329 
…ructure-risk_engine_apis
@WafaaNasr
run the non-default space tests only in ESS
2d4d139
@WafaaNasr
Merge branch 'main' of https://github.com/elastic/kibana into move-st…
53ac35a 
…ructure-risk_engine_apis
@nkhristinin
Remove size index from tests
459db4f
@WafaaNasr
Merge branch 'main' into move-structure-risk_engine_apis
ba832da
@WafaaNasr WafaaNasr marked this pull request as ready for review November 8, 2023 17:31
@WafaaNasr WafaaNasr requested review from a team as code owners November 8, 2023 17:31
@WafaaNasr WafaaNasr requested a review from a team as a code owner November 8, 2023 17:31
jbudz
jbudz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr_configs.yml

@WafaaNasr WafaaNasr mentioned this pull request Nov 9, 2023
Open
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

nkhristinin
nkhristinin approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your work!

@WafaaNasr WafaaNasr merged commit eeaf815 into elastic:main Nov 9, 2023
25 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 9, 2023
@WafaaNasr WafaaNasr deleted the move-structure-risk_engine_apis branch November 9, 2023 13:53
@nkhristinin
Copy link
Contributor

Flakky test runs:

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3948
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3954

@WafaaNasr WafaaNasr mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WafaaNasr @kibana-ci @nkhristinin @jbudz @kibanamachine