Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [FTR Test] Remove @skipInQA Tags from Tests #169770

Open
WafaaNasr opened this issue Oct 25, 2023 · 3 comments
Open

[Security Solution] [FTR Test] Remove @skipInQA Tags from Tests #169770

WafaaNasr opened this issue Oct 25, 2023 · 3 comments
Labels
FTR Project:Serverless Work as part of the Serverless project for its initial release Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage

Comments

@WafaaNasr
Copy link
Contributor

WafaaNasr commented Oct 25, 2023

Summary

Several tests currently have the unskipInQA tag applied to them. These tags were originally added to skip tests when running in the QA/MKI environment due to missing some user privileges, once the user gets fixed on the MKI env we need to enable these tests again

Related PRs/Tests

@WafaaNasr WafaaNasr added Team:Detection Engine Security Solution Detection Engine Area FTR test-coverage issues & PRs for improving code test coverage Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@WafaaNasr WafaaNasr added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 25, 2023
@WafaaNasr WafaaNasr changed the title [Security Solution] [FTR Test] Remove unskipInQA Tags from Tests [Security Solution] [FTR Test] Remove @skipInQA Tags from Tests Nov 9, 2023
@rylnd
Copy link
Contributor

rylnd commented Nov 15, 2023

@WafaaNasr is this still applicable? We have a lot of tests that aren't running due to this tag.

@WafaaNasr
Copy link
Contributor Author

WafaaNasr commented Nov 16, 2023

@rylnd Yes, this skipInQA tag is responsible for skipping solely the failing tests on the QA/MKI environment until they are addressed either by us or the Appex QA team.

We have a lot of tests that aren't running due to this tag.

Are you referring to the QA environment? If so, please go ahead and remove this tag if you discover that the mentioned tests have been resolved on the QA environment.

Here we track these tests so that we can address them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTR Project:Serverless Work as part of the Serverless project for its initial release Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage
Projects
None yet
Development

No branches or pull requests

3 participants