Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Enable API integration tests in Serverless, second quality gate #169185

Open
4 of 24 tasks
Tracked by #153633 ...
yctercero opened this issue Oct 17, 2023 · 2 comments
Open
4 of 24 tasks
Tracked by #153633 ...
Assignees
Labels
consider-next Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team test test-coverage issues & PRs for improving code test coverage

Comments

@yctercero
Copy link
Contributor

yctercero commented Oct 17, 2023

Epic: #153633
Depends on: #164445
Related to: #173327

Summary

We need to enable our FTRs to run against deployed projects. When running in CI, they are run against snapshots. This is usually referred to as MKI tests or second quality gate testing.

Tasks

Preview Give feedback

FTRs to enable

Preview Give feedback

Cypress to enable

Preview Give feedback
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 17, 2023
@yctercero yctercero added test test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Engine Security Solution Detection Engine Area consider-next and removed needs-team Issues missing a team label labels Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@WafaaNasr
Copy link
Contributor

WafaaNasr commented Nov 29, 2023

The majority of the detection engine and Rule Management API tests have been incorporated into the .buildkite/pipelines/security_solution/api_integration.yml pipeline step, related PR. Presently, it operates independently and is not a component of every PR; it runs as a distinct pipeline manually within the buildkite pipeline.

Some tests still require inclusion after relocating the remaining Rule Management-related tests. Upon completion of this task, we can proceed to close this ticket. Currently, there are failing tests in the MKI/QA environment, identified by the @skipInQA tag, and resolving these issues is the objective of this ticket at a later stage.

@yctercero yctercero added this to the D&R 8.14 milestone Feb 14, 2024
@yctercero yctercero modified the milestones: D&R 8.14, DR - Serverless Ungated Mar 26, 2024
yctercero added a commit that referenced this issue Mar 28, 2024
## Summary

Begins work on #169185 and
#151877 .

Related to #151877 this PR:
- Moves FTR tests under the `/alerts` folder that do not require
Platinum license into the basics folder. Tests in
`/alerts/trial_license_complete_tier` folder should now relate to
functionality that requires the higher license tier.
- Rearranged some of the folder structure so that it was clear what the
intent of the tests is
- Makes note of any issues in tickets that we will need to follow up on

Related to #169185 this PR:
- Ensures that tests are properly tagged for ESS & serverless
- Ensures none of the tests that are critical contain the `@skipInQA`
tag
@yctercero yctercero self-assigned this Mar 29, 2024
yctercero added a commit that referenced this issue Apr 2, 2024
## Summary

Continues work on #169185 and
#151877 . There wasn't a ton of
folder restructure, just switching the tests to run on basic
license/essentials tier and some test renaming for clarity sake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consider-next Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team test test-coverage issues & PRs for improving code test coverage
Projects
None yet
Development

No branches or pull requests

3 participants