Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Endpoint] Cypress Increase create policy task timeout #170001

Merged
merged 7 commits into from
Nov 9, 2023
Merged

[Security Solution] [Endpoint] Cypress Increase create policy task timeout #170001

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a59e116
Increase create policy task timeout
dasansol92 Oct 27, 2023
b7f4807
Merge branch 'main' into fix/olm-increase_create_policy_task_timeout
dasansol92 Nov 7, 2023
fd84354
Unskip tests
dasansol92 Nov 7, 2023
8003b3b
Increase timeout
dasansol92 Nov 8, 2023
a9fdf46
Increase timeout task instead of element
dasansol92 Nov 8, 2023
9309388
Revert package.json changes
dasansol92 Nov 8, 2023
6ba164c
Merge branch 'main' into fix/olm-increase_create_policy_task_timeout
kibanamachine Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions x-pack/plugins/security_solution/public/management/cypress/tasks/fleet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,20 @@ export const yieldEndpointPolicyRevision = (): Cypress.Chainable<number> =>

export const createAgentPolicyTask = (
version: string,
policyPrefix?: string
policyPrefix?: string,
timeout?: number
): Cypress.Chainable<IndexedFleetEndpointPolicyResponse> => {
const policyName = `${policyPrefix || 'Reassign'} ${Math.random().toString(36).substring(2, 7)}`;

return cy.task<IndexedFleetEndpointPolicyResponse>('indexFleetEndpointPolicy', {
policyName,
endpointPackageVersion: version,
agentPolicyName: policyName,
});
return cy.task<IndexedFleetEndpointPolicyResponse>(
'indexFleetEndpointPolicy',
{
policyName,
endpointPackageVersion: version,
agentPolicyName: policyName,
},
{ timeout: timeout ?? 5 * 60 * 1000 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: I'm guessing this is all in milliseconds so equivalent to 5 minutes? Maybe a comment would be nice just in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

);
};

export const enableAgentTamperProtectionFeatureFlagInPolicy = (agentPolicyId: string) => {
Expand Down