[Security Solution] [Endpoint] Cypress Increase create policy task timeout #170001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
ashokaditya
approved these changes
Oct 27, 2023
| endpointPackageVersion: version, | ||
| agentPolicyName: policyName, | ||
| }, | ||
| { timeout: timeout ?? 5 * 60 * 1000 } |
There was a problem hiding this comment.
Q: I'm guessing this is all in milliseconds so equivalent to 5 minutes? Maybe a comment would be nice just in case.
szwarckonrad
approved these changes
Nov 6, 2023
|
@szwarckonrad @ashokaditya I've reenabled skipped tests here in case you want to take another look. Thanks! |
This was referenced Nov 8, 2023
ashokaditya
approved these changes
Nov 8, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase policy task timeout to 5 minutes to avoid flaky tests.
For maintainers