Update incomplete data messaging

[nreese]

Closes #167906

PR breaks monolith component <SearchResponseWarnings/> into 3 separate components: <SearchResponseWarningsBadge/>, <SearchResponseWarningsCallout/>, and <SearchResponseWarningsEmptyPrompt/>. These components are designed to display a single messages when provided warnings from multiple requests and display better messaging around partial results. PR also removes message from SearchResponseWarning type.

Collaborated with @gchaps on copy.

Test setup

1. install sample web logs data set
2. install sample flights data set
3. Create data view.
   1. Set Index pattern to kibana_sample_data*
   2. Set Time field to timestamp
4. Open discover
5. Select kibana_sample_data* data view
6. set time range to last 24 hours
7. Add filter

   {
     "error_query": {
       "indices": [
         {
           "error_type": "exception",
           "message": "shard failure message 123",
           "name": "kibana_sample_data_logs",
           "shard_ids": [
             0
           ]
         }
       ]
     }
   }
   

8. save search as kibana_sample_data*

Search response warnings callout

1. Open saved search created in test setup
   
2. Click "expand" icon on left of first row in documents table
3. Click "Surrounding documents"
4. Re-enable "kibana_sample_data_logs failure" filter
   

Search response warnings empty prompt

1. Open saved search created in test setup
2. Add filter DistanceKilometers is -1
   

Search response warnings badge

1. create new dashboard
2. add saved search created during test setup
   

Search response warnings toast

1. create new table aggregation visualization
2. Use saved search created during test setup as source
   

[andreadelrio]

Looking good! Here's a suggestion to match the other empty prompts we show in Discover. Can you change the type of the button to use EuiButton instead?

Current

Suggested

@nreese can you let me know how this popover works? Could we add any more metadata to let the user know the difference between the options? (e.g. predecessor #1, predecessor #2, etc.)

[nreese]

@nreese can you let me know how this popover works? Could we add any more metadata to let the user know the difference between the options? (e.g. predecessor #1, predecessor #2, etc.)

The popover uses the request name as the button link. I can update to include a number if the names are duplicate

[nreese]

@elasticmachine merge upstream

[nreese]

@andreadelrio

Here's a suggestion to match the other empty prompts we show in Discover. Can you change the type of the button to use EuiButton instead?

Empty prompt now displays an EuiButton

@nreese can you let me know how this popover works? Could we add any more metadata to let the user know the difference between the options? (e.g. predecessor #1, predecessor #2, etc.)

Duplicate request names are now suffixed with a count to avoid duplicate text in UI.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 18d8b08

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
data	476	479	+3
discover	687	690	+3
lens	1133	1136	+3
visualizations	362	365	+3
total			+12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/search-response-warnings	7	12	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
data	47.4KB	46.8KB	-552.0B
discover	585.7KB	585.6KB	-113.0B
lens	1.4MB	1.4MB	+985.0B
visualizations	268.3KB	267.9KB	-432.0B
total			-112.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/search-response-warnings	2	1	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	410.1KB	411.1KB	+1.0KB

Unknown metric groups

async chunk count

id	before	after	diff
data	4	3	-1
discover	20	19	-1
lens	23	22	-1
visualizations	15	14	-1
total			-4

ESLint disabled line counts

id	before	after	diff
@kbn/search-response-warnings	1	0	-1

Total ESLint disabled count

id	before	after	diff
@kbn/search-response-warnings	1	0	-1

History

• 💔 Build #171402 failed dca5845
• 💚 Build #171374 succeeded 8e751f5
• 💔 Build #171259 failed d6aaece
• 💛 Build #170986 was flaky b0d9515
• 💔 Build #170977 failed 72066e0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jughosta]

LGTM 👍
Thanks!

[andreadelrio]

Duplicate request names are now suffixed with a count to avoid duplicate text in UI.

Thanks for the changes. When I look at what you've implemented it seems like a count (3 predecessors, 4 predecessors and so on), not a number representing an order. Is that the intent? Could we instead do 1. predecessor, 2. predecessor, 3. predecessor, ... , 7. anchor, ... through 13. sucessor? I'm trying to think of what will be of most help to the user when they look at this list.

[nreese]

Could we instead do 1. predecessor, 2. predecessor, 3. predecessor, ... , 7. anchor, ... through 13. sucessor? I'm trying to think of what will be of most help to the user when they look at this list.

The problem is that the component does not have any context about the requests (like order). Request creators need to provide meaningful names because they have required context. In this case, that would be up to Discover to provide sequential naming, or better yet - timestamped names. I would consider this outside the scope of this PR and a fix that @elastic/kibana-data-discovery team could make later.

[andreadelrio]

Could we instead do 1. predecessor, 2. predecessor, 3. predecessor, ... , 7. anchor, ... through 13. sucessor? I'm trying to think of what will be of most help to the user when they look at this list.

The problem is that the component does not have any context about the requests (like order). Request creators need to provide meaningful names because they have required context. In this case, that would be up to Discover to provide sequential naming, or better yet - timestamped names. I would consider this outside the scope of this PR and a fix that @elastic/kibana-data-discovery team could make later.

@kertal or @davismcphee can we please track this need somewhere? I'll approve now but want to make sure this doesn't get lost.

[andreadelrio]

Design changes LGTM. Hoping for follow-up to improve the View details popover in Surrounding Documents cc @elastic/kibana-data-discovery

[drewdaemon]

Works for me! Thanks! (code review for visualizations code)

[davismcphee]

@andreadelrio @nreese created an issue here: #170089.