Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables] remove panel error UI #157894

Closed
6 tasks
drewdaemon opened this issue May 16, 2023 · 4 comments
Closed
6 tasks

[Embeddables] remove panel error UI #157894

drewdaemon opened this issue May 16, 2023 · 4 comments
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

Based on discussion in #156811

We should

  1. Remove the ability for embeddables to use the EmbeddablePanel's error display UI via their output stream
  2. Make shared error display components available for use in individual embeddables (good candidates are Lens's VisualizationErrorPanel and EmbeddableMessagesPopover).
  3. Update all the embeddable types to make use of these components
  • Lens
  • Vega
  • Saved search
  • Maps
  • Canvas
  • ???
@drewdaemon drewdaemon added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 1, 2023
@drewdaemon
Copy link
Contributor Author

Make shared error display components available for use in individual embeddables (good candidates are Lens's VisualizationErrorPanel and EmbeddableMessagesPopover).

This has already been started in kbn-search-response-warnings package.

Lens will soon be using a shared badge component as of #169578

@ThomThomson
Copy link
Contributor

Closing this one as the new embeddable system will allow individual embeddables to show their own errors with a shared component.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants