Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Fix Diff TopN bug #169549

Merged
merged 3 commits into from
Oct 24, 2023
Merged

[Profiling] Fix Diff TopN bug #169549

merged 3 commits into from
Oct 24, 2023

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 23, 2023 •
edited by kibanamachine
Loading

Fixing this error that was happening when hovering over the grid.
Screenshot 2023-10-23 at 17 14 26

@cauemarcondes cauemarcondes requested a review from a team as a code owner October 23, 2023 16:16
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

jbcrail
jbcrail approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jbcrail jbcrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. 👍

The new component makes the logic easier to follow.

@cauemarcondes cauemarcondes requested a review from a team as a code owner October 24, 2023 08:38
@cauemarcondes cauemarcondes enabled auto-merge (squash) October 24, 2023 08:38
@cauemarcondes cauemarcondes mentioned this pull request Oct 24, 2023
Merged
1 task
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #3 / T1 and T2 analysts t1_analyst- READ + runSavedQueries "before all" hook for "should be able to run saved queries but not add new ones" "before all" hook for "should be able to run saved queries but not add new ones"
  • [job] [logs] Serverless Osquery Cypress Tests #3 / T1 and T2 analysts t2_analyst- READ + runSavedQueries "before all" hook for "should be able to run saved queries but not add new ones" "before all" hook for "should be able to run saved queries but not add new ones"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 356.9KB 357.2KB +289.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mdbirnstiehl
mdbirnstiehl approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cauemarcondes cauemarcondes merged commit 0a25b39 into elastic:main Oct 24, 2023
2 checks passed
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2023
@cauemarcondes
[Profiling] Fix Diff TopN bug (elastic#169549)
a276074 
Fixing this error that was happening when hovering over the grid.
<img width="1637" alt="Screenshot 2023-10-23 at 17 14 26"
src="https://github.com/elastic/kibana/assets/55978943/5baf2679-6803-4576-bb75-a52b41a902a0">

(cherry picked from commit 0a25b39)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.10 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.10:
- profiling: fix binary instructions (#169215)
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 169549

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2023
@kibanamachine @cauemarcondes
[8.11] [Profiling] Fix Diff TopN bug (#169549) (#169648)
34f92a2 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Profiling] Fix Diff TopN bug
(#169549)](#169549)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T12:53:14Z","message":"[Profiling]
Fix Diff TopN bug (#169549)\n\nFixing this error that was happening when
hovering over the grid.\r\n<img width=\"1637\" alt=\"Screenshot
2023-10-23 at 17 14
26\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/5baf2679-6803-4576-bb75-a52b41a902a0\">","sha":"0a25b39df25b61537c7c5aec9c441195f99845fd","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v8.11.0","v8.12.0","v8.10.5"],"number":169549,"url":"https://github.com/elastic/kibana/pull/169549","mergeCommit":{"message":"[Profiling]
Fix Diff TopN bug (#169549)\n\nFixing this error that was happening when
hovering over the grid.\r\n<img width=\"1637\" alt=\"Screenshot
2023-10-23 at 17 14
26\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/5baf2679-6803-4576-bb75-a52b41a902a0\">","sha":"0a25b39df25b61537c7c5aec9c441195f99845fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169549","number":169549,"mergeCommit":{"message":"[Profiling]
Fix Diff TopN bug (#169549)\n\nFixing this error that was happening when
hovering over the grid.\r\n<img width=\"1637\" alt=\"Screenshot
2023-10-23 at 17 14
26\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/5baf2679-6803-4576-bb75-a52b41a902a0\">","sha":"0a25b39df25b61537c7c5aec9c441195f99845fd"}},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@jbcrail jbcrail jbcrail approved these changes

Assignees
No one assigned
Labels
release_note:fix v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cauemarcondes @apmmachine @kibana-ci @kibanamachine @jbcrail @mdbirnstiehl