Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiling: fix binary instructions #169215

Merged
merged 7 commits into from
Oct 24, 2023
Merged

profiling: fix binary instructions #169215

merged 7 commits into from
Oct 24, 2023

Conversation

inge4pres
Copy link
Contributor

@inge4pres inge4pres commented Oct 18, 2023 •
edited by kibanamachine
Loading

Summary

Fix a bug in the Universal Profiling instructions "Binary" tab, due to how packages are created.

@inge4pres inge4pres added bug Fixes for quality problems that affect the customer experience backport release_note:skip Skip the PR/issue when compiling release notes v8.10.5 labels Oct 18, 2023
@inge4pres inge4pres self-assigned this Oct 18, 2023
@inge4pres inge4pres requested a review from a team as a code owner October 18, 2023 09:59
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 936dcc4 to 32203c2 Compare October 18, 2023 14:24
@inge4pres inge4pres added v8.11.1 v8.11.0 ci:cloud-deploy Create or update a Cloud deployment labels Oct 18, 2023
@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 49ef508 to 3c4b76e Compare October 18, 2023 16:10
@inge4pres inge4pres added the ci:cloud-redeploy Always create a new Cloud deployment label Oct 18, 2023
@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 3c4b76e to b6e9218 Compare October 18, 2023 16:11
@inge4pres
Copy link
Contributor Author

inge4pres commented Oct 18, 2023 •
edited
Loading

Before this PR
image

After
image

A similar view is applied to symbtool tab

@inge4pres
Copy link
Contributor Author

I tested both instructions and they are working as intended

@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from e659085 to bcb3d98 Compare October 18, 2023 20:03
@cauemarcondes
Copy link
Contributor

@inge4pres You need to fix the i18n key xpack.profiling.tabs.chmodXPf-host-agentpf-host-agentCodeBlockLabel replace it by something like xpack.profiling.addDataView.HA.agentCode

cauemarcondes
cauemarcondes approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions

x-pack/plugins/profiling/public/views/add_data_view/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/profiling/public/views/add_data_view/index.tsx Outdated Show resolved Hide resolved
@florianl
Copy link
Member

I just noticed this as well while testing 8.11.

@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 82ec4df to 00f6627 Compare October 19, 2023 13:41
@inge4pres inge4pres enabled auto-merge (squash) October 19, 2023 13:41
@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 00f6627 to 9c24820 Compare October 19, 2023 15:38
@inge4pres
Copy link
Contributor Author

@cauemarcondes what is the right way to fix this error?
https://buildkite.com/elastic/kibana-pull-request/builds/169542#018b4896-f142-4c92-acba-317d7ab92972/313-739

cauemarcondes
cauemarcondes reviewed Oct 19, 2023
View reviewed changes
x-pack/plugins/profiling/public/views/add_data_view/index.tsx Outdated
content: (
<EuiCodeBlock paddingSize="s" isCopyable>
{i18n.translate(
'xpack.profiling.tabs.kubectl-nUniversal-profilingGetCodeBlockLabel',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inge4pres please can you Remove the -, and create a better name for this key and all keys that were automatically generated? This is the reason why the CI is failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed them but there is still an error that i can't figure out how to fix 🤔

@inge4pres inge4pres force-pushed the profiling/fix-binary-instructions branch from 9c24820 to 2b68c17 Compare October 19, 2023 20:05
rockdaboot
rockdaboot approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes
Copy link
Contributor

@inge4pres I disabled a e2e test that is failing on all PRs... have to take a look on what's happening. But you're good to go.

@inge4pres
Copy link
Contributor Author

@inge4pres I disabled a e2e test that is failing on all PRs... have to take a look on what's happening. But you're good to go.

did I forget to update cypress test?
Are they failing because I changed the srtucture of the Add Data page?

If Yes, I am happy to amend them accordingly

@cauemarcondes
Copy link
Contributor

buildkite test this

@cauemarcondes
Copy link
Contributor

did I forget to update cypress test?

Not really, the broken test has nothing to do with your changes and it started failing out of nowhere. I'll have it fixed on another PR.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 24, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 356.6KB 356.9KB +336.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @inge4pres

@inge4pres inge4pres merged commit 90da021 into elastic:main Oct 24, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.10 Backport failed because of merge conflicts
❌ 8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 169215

Questions ?

Please refer to the Backport tool documentation

@inge4pres inge4pres deleted the profiling/fix-binary-instructions branch October 24, 2023 10:23
@inge4pres inge4pres mentioned this pull request Oct 24, 2023
Merged
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2023
Merged
@inge4pres inge4pres mentioned this pull request Oct 24, 2023
Merged
@inge4pres
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.11
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

inge4pres added a commit to inge4pres/kibana that referenced this pull request Oct 24, 2023
@inge4pres
profiling: fix binary instructions (elastic#169215)
b4d7c39 
## Summary

Fix a bug in the Universal Profiling instructions "Binary" tab, due to
how packages are created.

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit 90da021)

# Conflicts:
#	x-pack/plugins/profiling/public/views/add_data_view/index.tsx
inge4pres added a commit to inge4pres/kibana that referenced this pull request Oct 24, 2023
@inge4pres
profiling: fix binary instructions (elastic#169215)
c391ee0 
## Summary

Fix a bug in the Universal Profiling instructions "Binary" tab, due to
how packages are created.

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit 90da021)

# Conflicts:
#	x-pack/plugins/profiling/public/views/add_data_view/index.tsx
inge4pres added a commit that referenced this pull request Oct 24, 2023
@inge4pres
[8.11] profiling: fix binary instructions (#169215) (#169627)
43ad7c6 
# Backport

This will backport the following commits from `main` to `8.11`:
- [profiling: fix binary instructions
(#169215)](#169215)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T09:47:49Z","message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","release_note:skip","ci:cloud-deploy","ci:cloud-redeploy","v8.11.0","v8.12.0","v8.11.1","v8.10.5"],"number":169215,"url":"https://github.com/elastic/kibana/pull/169215","mergeCommit":{"message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169215","number":169215,"mergeCommit":{"message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2"}},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
inge4pres added a commit that referenced this pull request Oct 24, 2023
@inge4pres
[8.10] profiling: fix binary instructions (#169215) (#169657)
64486b1 
# Backport

This will backport the following commits from `main` to `8.10`:
- [profiling: fix binary instructions
(#169215)](#169215)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T09:47:49Z","message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","release_note:skip","ci:cloud-deploy","ci:cloud-redeploy","v8.11.0","v8.12.0","v8.11.1","v8.10.5"],"number":169215,"url":"https://github.com/elastic/kibana/pull/169215","mergeCommit":{"message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169215","number":169215,"mergeCommit":{"message":"profiling:
fix binary instructions (#169215)\n\n## Summary\r\n\r\nFix a bug in the
Universal Profiling instructions \"Binary\" tab, due to\r\nhow packages
are created.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"90da0214604dc8f497d997def664dab5b26543f2"}},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees

@inge4pres inge4pres

Labels
backport bug Fixes for quality problems that affect the customer experience ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.10.5 v8.11.0 v8.11.1 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@inge4pres @apmmachine @cauemarcondes @florianl @kibana-ci @kibanamachine @rockdaboot