Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Sumary query backward compatability #168817

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 13, 2023

Summary

Summary query backward compatibility !!

Testing

Easiest way to test this is to test this SNAPSHOT version against synthetics service prod locations

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review October 16, 2023 10:44
@shahzad31 shahzad31 requested a review from a team as a code owner October 16, 2023 10:44
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Oct 16, 2023
@shahzad31
Copy link
Contributor Author

/oblt-deploy

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 872 871 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 865.5KB 865.3KB -234.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LMK if you want me to make an issue for the broken failed tests columns or if you want to, or if there is some other fix already we can review.

@@ -39,6 +39,8 @@ export const FailedTestsList = ({

const formatter = useDateFormat();

// TODO: this is broken for ping monitors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create an issue for this then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take care of it

@shahzad31 shahzad31 merged commit 36cd0c6 into elastic:main Oct 16, 2023
@shahzad31 shahzad31 deleted the query-refactor branch October 16, 2023 16:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2023
## Summary

Summary query backward compatibility !!

### Testing

Easiest way to test this is to test this SNAPSHOT version against
synthetics service prod locations

(cherry picked from commit 36cd0c6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2023
…69001)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Synthetics] Sumary query backward compatability
(#168817)](#168817)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-16T16:24:58Z","message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.11.0","v8.12.0"],"number":168817,"url":"https://github.com/elastic/kibana/pull/168817","mergeCommit":{"message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168817","number":168817,"mergeCommit":{"message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
## Summary

Summary query backward compatibility !!


### Testing

Easiest way to test this is to test this SNAPSHOT version against
synthetics service prod locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants