-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Sumary query backward compatability #168817
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/oblt-deploy |
Pinging @elastic/uptime (Team:uptime) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, LMK if you want me to make an issue for the broken failed tests columns or if you want to, or if there is some other fix already we can review.
@@ -39,6 +39,8 @@ export const FailedTestsList = ({ | |||
|
|||
const formatter = useDateFormat(); | |||
|
|||
// TODO: this is broken for ping monitors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I create an issue for this then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take care of it
## Summary Summary query backward compatibility !! ### Testing Easiest way to test this is to test this SNAPSHOT version against synthetics service prod locations (cherry picked from commit 36cd0c6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…69001) # Backport This will backport the following commits from `main` to `8.11`: - [[Synthetics] Sumary query backward compatability (#168817)](#168817) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-16T16:24:58Z","message":"[Synthetics] Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test this is to test this SNAPSHOT version against\nsynthetics service prod locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.11.0","v8.12.0"],"number":168817,"url":"https://github.com/elastic/kibana/pull/168817","mergeCommit":{"message":"[Synthetics] Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test this is to test this SNAPSHOT version against\nsynthetics service prod locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168817","number":168817,"mergeCommit":{"message":"[Synthetics] Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test this is to test this SNAPSHOT version against\nsynthetics service prod locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
## Summary Summary query backward compatibility !! ### Testing Easiest way to test this is to test this SNAPSHOT version against synthetics service prod locations
Summary
Summary query backward compatibility !!
Testing
Easiest way to test this is to test this SNAPSHOT version against synthetics service prod locations